BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-11-13 07:26:23 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,463 Commits 23 Branches 50 Tags
9e6f17b94deab0ec6d7b7c8b2bc9641ef408b81e
Commit Graph
2 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Armen Baghumian f622e5996c Optimize get* operation 
It's slightly faster to convert the value to signed value in PHP as
opposed to use pack and unpack.

For 1M get operation the difference is:

    getShort in 3.3272678852081 seconds
    getInt in 3.8338589668274 seconds
    getLong in 5.6381590366364 seconds
    getLong (neg) in 5.6149101257324 seconds

vs

    getShort in 2.7564418315887 seconds
    getInt in 3.1612701416016 seconds
    getLong in 3.1369340419769 seconds
    getLong (neg) in 3.1478710174561 seconds

And since pack("P") and unpack("q") has been removed now ByteBuffer
works for PHP >= 5.4
 2015-12-05 23:32:35 +00:00
Armen Baghumian 77fbdd28e2 Correct the max/min signed/unsigned 32-bit int 
The test was trying to pack an unsigned int which couldn't fit as a
signed int and putInt() wasn't doing the validation in the correct range
 2015-12-05 23:32:35 +00:00