BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-01 19:58:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make type conversions explicit. (#7595)

Browse Source 
As Java does not support unsigned integer types, the value types
are "rounded up" (an uint32 is represented as a long) but persisted
correctly (an uint32 is persisted as 4 bytes).

This CL makes a cast operation explicit so that the compiler
does not throw warning messages.

Co-authored-by: Dominic Battre <battre@chromium.org>
Co-authored-by: Derek Bailey <derekbailey@google.com>
This commit is contained in:
Dominic Battre
2022-10-21 18:09:28 +02:00
committed by GitHub
parent f7b734438d
commit e301702964
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/pom.xml
View File

@@ -64,7 +64,6 @@
<release>8</release>
<testExcludes>
<testExclude>MyGame/Example/MonsterStorageGrpc.java</testExclude>
<testExclude>MyGame/Example/StructOfStructs**</testExclude>
<testExclude>MyGame/OtherNameSpace/TableBT.java</testExclude>
</testExcludes>
</configuration>

1
src/idl_gen_java.cpp
View File

@@ -1893,6 +1893,7 @@ class JavaGenerator : public BaseGenerator {
}
} else {
code += " " + name + " = ";
code += SourceCast(field_type);
code += "_o";
for (size_t i = 0; i < array_lengths.size(); ++i) {
code += "." + namer_.Method("get", array_lengths[i].name) + "()";

8
tests/MyGame/Example/StructOfStructs.java
View File

@@ -52,12 +52,12 @@ public final class StructOfStructs extends Struct {
}
public static int pack(FlatBufferBuilder builder, StructOfStructsT _o) {
if (_o == null) return 0;
int _a_id = _o.getA().getId();
int _a_distance = _o.getA().getDistance();
int _a_id = (int) _o.getA().getId();
int _a_distance = (int) _o.getA().getDistance();
short _b_a = _o.getB().getA();
byte _b_b = _o.getB().getB();
int _c_id = _o.getC().getId();
int _c_distance = _o.getC().getDistance();
int _c_id = (int) _o.getC().getId();
int _c_distance = (int) _o.getC().getDistance();
return createStructOfStructs(
builder,
_a_id,

8
tests/MyGame/Example/StructOfStructsOfStructs.java
View File

@@ -47,12 +47,12 @@ public final class StructOfStructsOfStructs extends Struct {
}
public static int pack(FlatBufferBuilder builder, StructOfStructsOfStructsT _o) {
if (_o == null) return 0;
int _a_a_id = _o.getA().getA().getId();
int _a_a_distance = _o.getA().getA().getDistance();
int _a_a_id = (int) _o.getA().getA().getId();
int _a_a_distance = (int) _o.getA().getA().getDistance();
short _a_b_a = _o.getA().getB().getA();
byte _a_b_b = _o.getA().getB().getB();
int _a_c_id = _o.getA().getC().getId();
int _a_c_distance = _o.getA().getC().getDistance();
int _a_c_id = (int) _o.getA().getC().getId();
int _a_c_distance = (int) _o.getA().getC().getDistance();
return createStructOfStructsOfStructs(
builder,
_a_a_id,