BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-07 05:47:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removes the inner loop in the endtable check written tables (#5803)

Browse Source
This commit is contained in:
mustiikhalil
2020-03-12 22:13:03 +03:00
committed by GitHub
parent 0e3fdd0eea
commit 0dba63909f
2 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
swift/Sources/FlatBuffers/ByteBuffer.swift
View File

@@ -118,7 +118,7 @@ public final class ByteBuffer {
/// - size: Size of Value being written to the buffer
func push(struct value: UnsafeMutableRawPointer, size: Int) {
ensureSpace(size: UInt32(size))
_memory.advanced(by: writerIndex - size).copyMemory(from: value, byteCount: size)
memcpy(_memory.advanced(by: writerIndex - size), value, size)
defer { value.deallocate() }
_writerSize += size
}

22
swift/Sources/FlatBuffers/FlatBufferBuilder.swift
View File

@@ -174,19 +174,17 @@ public final class FlatBufferBuilder {
var isAlreadyAdded: Int?
mainLoop: for table in _vtables {
let vt1 = _bb.capacity - Int(table)
let vt2 = _bb.writerIndex
let len = _bb.read(def: Int16.self, position: vt1)
guard len == _bb.read(def: Int16.self, position: vt2) else { break }
for i in stride(from: sizeofVoffset, to: Int(len), by: sizeofVoffset) {
let vt1ReadValue = _bb.read(def: Int16.self, position: vt1 + i)
let vt2ReadValue = _bb.read(def: Int16.self, position: vt2 + i)
if vt1ReadValue != vt2ReadValue {
break mainLoop
}
}
let vt2 = _bb.memory.advanced(by: _bb.writerIndex)
let len2 = vt2.load(fromByteOffset: 0, as: Int16.self)
for table in _vtables {
let position = _bb.capacity - Int(table)
let vt1 = _bb.memory.advanced(by: position)
let len1 = _bb.read(def: Int16.self, position: position)
if (len2 != len1 || 0 != memcmp(vt1, vt2, Int(len2))) { continue }
isAlreadyAdded = Int(table)
break
}
if let offset = isAlreadyAdded {