Wouter van Oortmerssen
e837d5a296
Fixed deprecated method in GRPC Java test.
...
Change-Id: Iccae8fe9409adbf3cd3013a5cf3368e068175ad3
2019-11-04 17:23:01 -08:00
Wouter van Oortmerssen
9834ee9787
Fixed Apache license not using canonical version.
...
Now identical to https://www.apache.org/licenses/LICENSE-2.0.txt
Change-Id: I6eab8bdee2472107dfc72265e204fdd16f3abc2e
2019-11-04 17:15:56 -08:00
Even Rouault
44b2ab087c
include/flatbuffers/base.h: fix no_sanitize issue with old clang ( #5610 )
...
Older clang versions raise:
```
./flatbuffers/base.h:365:1: error: unknown attribute 'no_sanitize' ignored [-Werror,-Wattributes]
__supress_ubsan__("alignment")
^
./flatbuffers/base.h:246:50: note: expanded from macro '__supress_ubsan__'
#define __supress_ubsan__(type) __attribute__((no_sanitize(type)))
^
```
Comparing https://releases.llvm.org/3.6.0/tools/clang/docs/AttributeReference.html
with https://releases.llvm.org/3.7.0/tools/clang/docs/AttributeReference.html
shows that __attribute__((no_sanitize(type))) is available since 3.7.0
2019-11-04 14:58:51 -08:00
Derek Bailey
46ae3f80a6
[C++, Java, C#, TypeScript, JavaScript] Skip generation of mutable union types ( #5599 )
...
* Skip generation of mutable union types
* Removed C# and Java unit tests that mutated a Union type
2019-11-04 14:54:44 -08:00
Even Rouault
7b38aa71e6
flatbuffers.h: fix documentation warning ( #5607 )
...
Fixes following clang -Wdocumentation warning:
```
flatbuffers.h:1762:17: error: parameter ']' not found in the function declaration [-Werror,-Wdocumentation]
/// @param[in]] v A const reference to the `std::vector` of structs to
```
2019-11-04 14:28:33 -08:00
Derek Bailey
661bedd837
Add Lua FlatbufferBuilder Clean() method to enable reuseable builders ( #5606 )
2019-11-04 14:27:59 -08:00
Paulo Pinheiro
8526e12d73
[Kotlin] Fix union vector accessor after change in Java API ( #5605 )
...
Kolin uses java library as dependency, which changed the way it access union vector recently
(e365c502ff ).
This changes updates kotlin code generation to match Java's changes.
2019-11-04 14:25:07 -08:00
Paulo Pinheiro
3c7b660d62
[flatc] Remove an always true condition for flexbuffers ( #5604 )
...
The condition was unnecessary and Detected by
PVS-Studio
V560 [CWE-571] A part of conditional expression is always true: !opts.use_flexbuffers. flatc.cpp 438
2019-11-04 14:23:15 -08:00
Lawrence Chan
964365ba69
[Go] Add UnPackTo functions ( #5598 )
2019-11-04 12:12:25 -08:00
iceboy
32254b7acd
[Go] Object API support ( #5339 )
...
* start
* works for current usages!
* unpack: vector of struct
* optimize byte slice
* support nested struct
* support null table
* support struct
* support union
* update generated code
* grumble
* fix compiler warning
* update generated code
* wrap type in namespace
* bug
* wrap in namespace
* enum byte arrays
* generate struct for unions
* basic testing
* remove branching
* fix assert
* pack vector of fixed structs correctly
* omit null vectors
* Refactor Union Pack and UnPack methods
Remove append usage to increase code efficiency when dealing with large vectors
* generate goldens
2019-10-31 11:13:45 -07:00
Mathias Svensson
521e255ad9
Rust: Add idiomatic iterator for Vector type ( #5579 )
...
* Rust: Add idiomatic iterator for Vector type
* Add comments explaining some implementation details
2019-10-28 14:19:47 -04:00
Even Rouault
1b85292fd3
Fix typos in comments ( #5590 )
...
Found by the https://github.com/OSGeo/gdal/blob/master/gdal/scripts/fix_typos.sh
script on the internal copy of flatbuffers inside GDAL
2019-10-28 10:02:46 -07:00
Derek Bailey
480815447a
C++ verifier for evolved union fields should return true ( #5586 )
2019-10-28 09:43:33 -07:00
Derek Bailey
8d5e424c65
Add ByteBuffer copy for vector of bytes in Java ( #5587 )
2019-10-28 09:30:31 -07:00
Mathias Svensson
b4774d2354
Rust: Fix Copy and Clone impls for a few generic types ( #5577 )
...
* Rust: Fix Copy and Clone impls for a few generic types
* Add tests for Copy+Clone
* Wrap Copy+Clone checks in a #[test] function
2019-10-28 00:20:29 -04:00
Vladimir Glavnyy
26f238c248
Add --clean-first to the cmake-build command (travis) ( #5574 )
...
- `--clean-first` runs `clean` target to remove previously generated files
- missed `monster_extra_generated.h` file added to the `flattests` target
2019-10-21 10:11:32 -07:00
StackDoubleFlow
e93c8c46e6
Fix Follow implementation for bool ( #5554 )
2019-10-19 23:24:13 -04:00
Vladimir Glavnyy
e21516b9d7
Fix issue #5557 ( #5573 )
...
- remove not necessary file `monster_test_generated.h` from sample_bfbs.cpp
2019-10-18 10:16:55 -07:00
Björn Harrtell
fbc11e8aec
Avoid intentional unsigned integer overflow getting caught by sanitizers ( #5572 )
...
* Avoid intentional unsigned integer overflow getting caught by sanitizers
* Adapt from suggested compiler compatible solution
* And a third way :)
2019-10-17 15:47:51 -07:00
Bharat Tak
e9d29c21a7
Python: Add forceDefaults opt to python Builder ( #5564 )
...
* Add forceDefaults opt to python Builder
* Add test functions for force_default option for python builder
* Simplify
* Add force default test for UOffsetTFlags
2019-10-17 15:25:05 -07:00
Jacek Surazski
8bfafc76de
Java: Don't annotate vector-of-tables item getters with @nullable. ( #5562 )
...
* Annotate getters with @Pure when --java-checkerframework is specified.
Together with @Nullable, this allows users to use static analysis tools
like CheckerFramework to catch NPEs caused by unset fields.
* Don't annotate vector-of-tables item getters with @Nullable.
Since Flatbuffers don't support null items in vectors of tables.
2019-10-17 15:23:15 -07:00
Wouter van Oortmerssen
df3e8bf4a7
Fixed warnings generated by recent JSON sorting feature.
...
Change-Id: I6fd6283b616c7a39bb878b1610e4ddf6e208fa0a
2019-10-17 15:16:40 -07:00
Idan Sheinberg
5665cfe492
[Java] byte buffer factory returned buffer capcity is used instead of the requested size ( #5558 )
...
* byte buffer factory returned buffer is used instead of the requested capacity
* byte buffer factory returned buffer is used instead of the requested capacity
* Comment fix
2019-10-17 15:11:33 -07:00
tira-misu
5797540ed0
#5544 Fix of Array of table is not sorted if Create<type>Direct() is used ( #5546 )
...
* Fix C/C++ Create<Type>Direct with sorted vectors
If a struct has a key the vector has to be sorted. To sort the vector
you can't use "const".
* Changes due to code review
* Improve code readability
2019-10-17 14:22:21 -07:00
Brian Harris
7f1af7cb02
Fix build with gcc version 7.4.0 ( #5570 )
2019-10-15 10:56:58 -07:00
Wouter van Oortmerssen
32f47ad247
Fixed JSON parser not sorting vectors of tables/structs with key.
...
Change-Id: Iacc0c8513af80a736700e6cbaf513ebdf8e3ac89
2019-10-10 15:25:39 -07:00
Paulo Pinheiro
842f672baf
[FlexBuffers][Java] Cache size of Sized objects in FlexBuffers ( #5551 )
...
In my benchmarks it shows deserialization performance improvements of
around 7%
2019-10-03 15:56:29 -07:00
Paulo Pinheiro
d4cae0a623
Fix issue #5542 ( #5543 )
...
Empty objects that inherit from Sized would try to access internal
ByteBuffer when Sized::size was called. So we add a single byte in
the empty buffer, so when size() is called it would return 0
2019-09-30 14:05:19 -07:00
Wouter van Oortmerssen
f1147f65bb
Fixed Android STLPort related error.
...
Change-Id: I59ff072e526fc63b3215767a4d4a2a8944b65654
2019-09-30 12:12:36 -07:00
Jack Zhou
69d3fec488
Fix namespaced struct/field name collision detection ( #5540 ) ( #5545 )
...
Changes the use of `LookupStruct` to `LookupCreateStruct` in
`ParseField` to also detect when collisions happen in namespaces.
2019-09-30 11:50:03 -07:00
Paulo Pinheiro
cfb4ecf6f0
[flac] Add FlexBuffers option for generating data ( #5519 )
...
Alongside --binary and --json, an additional
switch (--flexbuffers) can be passed to convert
data using FlexBuffers
2019-09-26 15:06:11 -07:00
Robert Winslow
a92039687a
Update Rust versions under test from 1.30.1 to 1.37.0 ( #5538 )
...
Fixes build errors from using newer crate versions with an old Rust version.
2019-09-26 14:31:11 -07:00
mjvk
625338d095
Adds XOPEN_SOURCE for PATH_MAX and POSIX 1993 for stat ( #5529 )
...
* Adds XOPEN_SOURCE for PATH_MAX and POSIX 1993 for stat
These are the only two required extension for compilation of
flatbuffers using -std=c++11 instead of gnu++11.
* Sets _XOPEN_SOURCE to 600 and enable POSIX2001 for fseeko
2019-09-26 09:40:14 -07:00
Paulo Pinheiro
3f8ce99c50
[FlexBuffers][Java] Add override Key::toString ( #5533 )
2019-09-25 14:14:39 -07:00
Paulo Pinheiro
0798b7b698
[FlexBuffers][Java] Fix wrong access to a string using Reference::asString(). ( #5532 )
...
The real position of a string is calculated by using the indirect() method,
which should be based on parentWidth and not byteWidth, as it was implemented.
We are also fixing the flag BUILDER_FLAG_SHARE_STRINGS on FlexBuffersBuilder
that was set as '1', same value as BUILDER_FLAG_SHARE_KEYS.
2019-09-25 11:59:10 -07:00
Vladimir Glavnyy
cbdf82e2fb
Fix Mutate() methods of Array<scalar/struct> (override 5508) ( #5526 )
...
* Draft with Array specialization (#5508 )
* Array specialization + SFINAE to fold copy-paste (#5508 )
* Add implicit specialization of Array<scalar> and Array<struct> (#5508 )
- Tag dispatching is used for implicit specialization
- Array<scalar> and Array<struct> have different iterators and accessors
- Array<scalar> and Array<struct> have different Mutate() methods
* Add implicit specialization of Array<scalar> and Array<struct> (#5508 )
- Tag dispatching is used for implicit specialization
- Array<scalar> and Array<struct> have different iterators and accessors
- Array<scalar> and Array<struct> have different Mutate() methods
2019-09-23 09:31:51 -07:00
Kulikov Alexey
e365c502ff
Java: Added access object for vector of struct and vector of tables. ( #5233 )
...
* Java: Added access object for vector of struct and vector of tables.
* Java: Workarounds removed when accessing the union vector.
2019-09-23 09:22:43 -07:00
mmoscicki2
97f3aa9174
Fixed DetachedBuffer self move assignment ( #5521 )
2019-09-19 10:32:24 -07:00
Austin Schuh
2f5bb2eec4
Fix buildifier warnings found in new bazel ( #5517 )
...
Fixes warnings caught in:
https://buildkite.com/bazel/flatbuffers/builds/863#cff87e1d-b976-4734-8157-4b6d88c7b5e1
2019-09-19 09:58:36 -07:00
Wouter van Oortmerssen
917687c7a6
Fixed Reflection Verifier not handling vectors of unions.
...
Change-Id: Ie94386ff8e10fd2a964bd9155139b50953746a37
2019-09-16 17:48:54 -07:00
Wouter van Oortmerssen
f9277e691d
Fixed GenerateText not handling vectors of unions.
...
Change-Id: Ie82abaf178495c4692e7d10be6b4a13f2fa1bee6
2019-09-16 14:44:14 -07:00
Kevin Fort
2706381eef
Add element size parameter to __vector_as_arraysegment [c#] ( #5512 )
...
* Add element size parameter to __vector_as_arraysegment
Add element size parameter to __vector_as_arraysegment fixing issue where VectorAsBytes returns incorrect size span for multibyte element types.
* Update codegen
Update codegen and Table to return typed span.
* update test files
update test files
2019-09-10 17:07:46 -07:00
Paulo Pinheiro
b5560fcd52
[Java][FlexBuffers] Improve documentation for FlexBuffers in Java. ( #5506 )
...
Also add a FlexBuffer constructor to simplify usage
2019-09-10 10:06:47 -07:00
jaceksur
782b865c55
Annotate getters with @Pure when --java-checkerframework is specified. ( #5510 )
...
Together with @Nullable, this allows users to use static analysis tools
like CheckerFramework to catch NPEs caused by unset fields.
2019-09-10 10:01:27 -07:00
Edward
3bfc86eaff
[Dart]fix: segment fault with empty namespace when generating dart file ( #5507 )
...
* fix: segment fault with empty namespace when generating dart file
* fix: compile err
* fix: compile err
* fix: imported file names
* fix test issues
* fix some language style issues
2019-09-09 14:40:33 -07:00
Casper
c0282873fb
Rust: Fixed cargo clippy on non-generated code ( #5485 )
...
* Cargo clippy lints
* more lints
* more lints
* Restored a doc comment
* Comment on float eps-eq and adjusted casting
2019-09-09 13:02:43 -07:00
Jaemin Park
4b870aca98
[Javascript] Fix syntax error for signed enum ( #5503 )
...
* wrap quotes to enum name map to prevent syntax errorn when enum value is negative
* Add a test that covers signed enum case
2019-09-05 10:22:04 -07:00
Nathan Williams
d0e3870c0f
[C#] Fix retrieving enumeration vectors as arrays ( #5457 )
...
* [C#] Fix retrieving enumeration vectors as arrays
* [C#] Don't generate CreateVectorBlock for enums
2019-09-03 14:10:54 -07:00
Björn Harrtell
fb25eb87f2
Doc typo fixes ( #5505 )
2019-09-03 11:50:42 -07:00
Morten Grouleff
cb35d3a0e5
Use all of the available space in the buffer returned by ByteBufferFactory to allow the factory to keep a pool of larger than initialsize sized buffers. ( #5500 )
2019-09-03 11:13:32 -07:00