Run clang-format -i **/*.cpp (#8865)

This commit is contained in:
Derek Bailey
2025-12-19 10:42:57 -08:00
committed by GitHub
parent d9fde67eb5
commit fb55e0c9de
24 changed files with 213 additions and 192 deletions

View File

@@ -15,15 +15,17 @@
*/ */
#include <jni.h> #include <jni.h>
#include <string>
#include <search.h> #include <search.h>
#include <string>
#include "generated/animal_generated.h" #include "generated/animal_generated.h"
using namespace com::fbs::app; using namespace com::fbs::app;
using namespace flatbuffers; using namespace flatbuffers;
extern "C" JNIEXPORT jbyteArray JNICALL Java_com_flatbuffers_app_MainActivity_createAnimalFromJNI( extern "C" JNIEXPORT jbyteArray JNICALL
JNIEnv* env, Java_com_flatbuffers_app_MainActivity_createAnimalFromJNI(JNIEnv* env,
jobject /* this */) { jobject /* this */) {
// create a new animal flatbuffers // create a new animal flatbuffers
auto fb = FlatBufferBuilder(1024); auto fb = FlatBufferBuilder(1024);

View File

@@ -33,7 +33,9 @@ static inline void Use(benchmark::State &state, std::unique_ptr<Bench> &bench,
int64_t sum = 0; int64_t sum = 0;
for (auto _ : state) { sum = bench->Use(decoded); } for (auto _ : state) {
sum = bench->Use(decoded);
}
EXPECT_EQ(sum, check_sum); EXPECT_EQ(sum, check_sum);
} }

View File

@@ -1,12 +1,12 @@
#include "greeter.grpc.fb.h"
#include "greeter_generated.h"
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <iostream> #include <iostream>
#include <memory> #include <memory>
#include <string> #include <string>
#include "greeter.grpc.fb.h"
#include "greeter_generated.h"
class GreeterClient { class GreeterClient {
public: public:
GreeterClient(std::shared_ptr<grpc::Channel> channel) GreeterClient(std::shared_ptr<grpc::Channel> channel)

View File

@@ -1,12 +1,12 @@
#include "greeter.grpc.fb.h"
#include "greeter_generated.h"
#include <grpcpp/grpcpp.h> #include <grpcpp/grpcpp.h>
#include <iostream> #include <iostream>
#include <memory> #include <memory>
#include <string> #include <string>
#include "greeter.grpc.fb.h"
#include "greeter_generated.h"
class GreeterServiceImpl final : public Greeter::Service { class GreeterServiceImpl final : public Greeter::Service {
virtual grpc::Status SayHello( virtual grpc::Status SayHello(
grpc::ServerContext* context, grpc::ServerContext* context,

View File

@@ -470,7 +470,8 @@ class FlatBufferBuilderImpl {
for (auto it = buf_.scratch_data(); it < buf_.scratch_end(); for (auto it = buf_.scratch_data(); it < buf_.scratch_end();
it += sizeof(uoffset_t)) { it += sizeof(uoffset_t)) {
auto vt_offset_ptr = reinterpret_cast<uoffset_t*>(it); auto vt_offset_ptr = reinterpret_cast<uoffset_t*>(it);
auto vt2 = reinterpret_cast<voffset_t *>(buf_.data_at(*vt_offset_ptr + length_of_64_bit_region_)); auto vt2 = reinterpret_cast<voffset_t*>(
buf_.data_at(*vt_offset_ptr + length_of_64_bit_region_));
auto vt2_size = ReadScalar<voffset_t>(vt2); auto vt2_size = ReadScalar<voffset_t>(vt2);
if (vt1_size != vt2_size || 0 != memcmp(vt2, vt1, vt1_size)) continue; if (vt1_size != vt2_size || 0 != memcmp(vt2, vt1, vt1_size)) continue;
vt_use = *vt_offset_ptr; vt_use = *vt_offset_ptr;

View File

@@ -410,7 +410,6 @@ FLATBUFFERS_CONSTEXPR_CPP11 flatbuffers::span<const U> make_structs_span(
#endif #endif
// Represent a vector much like the template above, but in this case we // Represent a vector much like the template above, but in this case we
// don't know what the element types are (used with reflection.h). // don't know what the element types are (used with reflection.h).
class VectorOfAny { class VectorOfAny {

View File

@@ -14,12 +14,12 @@
* limitations under the License. * limitations under the License.
*/ */
#include "flatbuffers/file_manager.h"
#include <fstream> #include <fstream>
#include <set> #include <set>
#include <string> #include <string>
#include "flatbuffers/file_manager.h"
namespace flatbuffers { namespace flatbuffers {
bool RealFileSaver::SaveFile(const char* name, const char* buf, size_t len, bool RealFileSaver::SaveFile(const char* name, const char* buf, size_t len,

View File

@@ -652,17 +652,21 @@ class CSharpGenerator : public BaseGenerator {
// Get the getter for the key of the struct. // Get the getter for the key of the struct.
if (IsString(key_field->value.type)) { if (IsString(key_field->value.type)) {
return "string.CompareOrdinal(" + return "string.CompareOrdinal(" +
GenGetterForLookupByKey(struct_def, key_field, "builder.DataBuffer", GenGetterForLookupByKey(struct_def, key_field,
"builder.DataBuffer",
"builder.DataBuffer.Length - o1.Value") + "builder.DataBuffer.Length - o1.Value") +
", " + ", " +
GenGetterForLookupByKey(struct_def, key_field, "builder.DataBuffer", GenGetterForLookupByKey(struct_def, key_field,
"builder.DataBuffer",
"builder.DataBuffer.Length - o2.Value") + "builder.DataBuffer.Length - o2.Value") +
")"; ")";
} else { } else {
return GenGetterForLookupByKey(struct_def, key_field, "builder.DataBuffer", return GenGetterForLookupByKey(struct_def, key_field,
"builder.DataBuffer",
"builder.DataBuffer.Length - o1.Value") + "builder.DataBuffer.Length - o1.Value") +
".CompareTo(" + ".CompareTo(" +
GenGetterForLookupByKey(struct_def, key_field, "builder.DataBuffer", GenGetterForLookupByKey(struct_def, key_field,
"builder.DataBuffer",
"builder.DataBuffer.Length - o2.Value") + "builder.DataBuffer.Length - o2.Value") +
")"; ")";
} }
@@ -1596,7 +1600,8 @@ class CSharpGenerator : public BaseGenerator {
code += " obj_.__assign(tableOffset, bb);\n"; code += " obj_.__assign(tableOffset, bb);\n";
if (IsString(key_field->value.type)) { if (IsString(key_field->value.type)) {
code += " int comp = string.CompareOrdinal(obj_." + name + ", key);\n"; code +=
" int comp = string.CompareOrdinal(obj_." + name + ", key);\n";
} else { } else {
code += " int comp = obj_." + name + ".CompareTo(key);\n"; code += " int comp = obj_." + name + ".CompareTo(key);\n";
} }

View File

@@ -1468,7 +1468,8 @@ class JavaGenerator : public BaseGenerator {
" " + variable_name + "Type = " + field_name + "Type(" + " " + variable_name + "Type = " + field_name + "Type(" +
type_params + ");\n"; type_params + ");\n";
code += indent + variable_name + ".setType(" + variable_name + "Type);\n"; code += indent + variable_name + ".setType(" + variable_name + "Type);\n";
code += indent + "com.google.flatbuffers.Table " + variable_name + "Value;\n"; code +=
indent + "com.google.flatbuffers.Table " + variable_name + "Value;\n";
code += indent + "switch (" + variable_name + "Type) {\n"; code += indent + "switch (" + variable_name + "Type) {\n";
for (auto eit = enum_def.Vals().begin(); eit != enum_def.Vals().end(); for (auto eit = enum_def.Vals().begin(); eit != enum_def.Vals().end();
++eit) { ++eit) {

View File

@@ -1216,8 +1216,8 @@ class KotlinGenerator : public BaseGenerator {
// fun inventoryInByteBuffer(_bb: Bytebuffer): // fun inventoryInByteBuffer(_bb: Bytebuffer):
// ByteBuffer? = __vector_as_bytebuffer(_bb, 14, 1) // ByteBuffer? = __vector_as_bytebuffer(_bb, 14, 1)
GenerateFunOneLine( GenerateFunOneLine(
writer, field_name + "InByteBuffer", "_bb: ByteBuffer", writer, field_name + "InByteBuffer", "_bb: ByteBuffer", buffer_type,
buffer_type, [&]() { [&]() {
writer.SetValue("end", end_idx); writer.SetValue("end", end_idx);
writer += "__vector_in_bytebuffer(_bb, {{offset}}, {{end}})"; writer += "__vector_in_bytebuffer(_bb, {{offset}}, {{end}})";
}); });

View File

@@ -2885,8 +2885,7 @@ class PythonGenerator : public BaseGenerator {
EnsureDirExists(directories); EnsureDirExists(directories);
for (size_t i = directories.find(kPathSeparator, path_.size()); for (size_t i = directories.find(kPathSeparator, path_.size());
i != std::string::npos; i != std::string::npos; i = directories.find(kPathSeparator, i + 1)) {
i = directories.find(kPathSeparator, i + 1)) {
const std::string init_py = const std::string init_py =
directories.substr(0, i) + kPathSeparator + "__init__.py"; directories.substr(0, i) + kPathSeparator + "__init__.py";
parser_.opts.file_saver->SaveFile(init_py.c_str(), "", false); parser_.opts.file_saver->SaveFile(init_py.c_str(), "", false);
@@ -2913,7 +2912,8 @@ static const char* GeneratePython(const Parser& parser, const std::string& path,
if (parser.opts.python_typing) { if (parser.opts.python_typing) {
python::PythonStubGenerator stub_generator(parser, path, version); python::PythonStubGenerator stub_generator(parser, path, version);
if (!stub_generator.Generate()) return "could not generate Python type stubs"; if (!stub_generator.Generate())
return "could not generate Python type stubs";
} }
return nullptr; return nullptr;
} }
@@ -2948,7 +2948,8 @@ class PythonCodeGenerator : public CodeGenerator {
Status GenerateGrpcCode(const Parser& parser, const std::string& path, Status GenerateGrpcCode(const Parser& parser, const std::string& path,
const std::string& filename) override { const std::string& filename) override {
if (!GeneratePythonGRPC(parser, path, filename)) { // TODO add status GeneratePythonGRPC if (!GeneratePythonGRPC(parser, path,
filename)) { // TODO add status GeneratePythonGRPC
return Status::ERROR; return Status::ERROR;
} }
return Status::OK; return Status::OK;

View File

@@ -1347,7 +1347,8 @@ class SwiftGenerator : public BaseGenerator {
} }
void GenerateObjectAPIStructConstructor(const StructDef& struct_def) { void GenerateObjectAPIStructConstructor(const StructDef& struct_def) {
code_ += "{{ACCESS_TYPE}} init(_ _t: borrowing {{STRUCTNAME}}" + Mutable() + ") {"; code_ += "{{ACCESS_TYPE}} init(_ _t: borrowing {{STRUCTNAME}}" + Mutable() +
") {";
Indent(); Indent();
for (auto it = struct_def.fields.vec.begin(); for (auto it = struct_def.fields.vec.begin();
it != struct_def.fields.vec.end(); ++it) { it != struct_def.fields.vec.end(); ++it) {
@@ -1393,7 +1394,8 @@ class SwiftGenerator : public BaseGenerator {
base_constructor); base_constructor);
} }
code_ += ""; code_ += "";
BuildObjectConstructor(buffer_constructor, BuildObjectConstructor(
buffer_constructor,
"_ _t: borrowing " + namer_.NamespacedType(struct_def)); "_ _t: borrowing " + namer_.NamespacedType(struct_def));
BuildObjectConstructor(base_constructor); BuildObjectConstructor(base_constructor);
if (!struct_def.fixed) if (!struct_def.fixed)

View File

@@ -339,8 +339,7 @@ class TsGenerator : public BaseGenerator {
for (auto it = dc.begin(); it != dc.end(); ++it) { for (auto it = dc.begin(); it != dc.end(); ++it) {
if (indent) code += indent; if (indent) code += indent;
std::string safe = *it; std::string safe = *it;
for (size_t pos = 0; for (size_t pos = 0; (pos = safe.find("*/", pos)) != std::string::npos;) {
(pos = safe.find("*/", pos)) != std::string::npos;) {
safe.replace(pos, 2, "*\\/"); safe.replace(pos, 2, "*\\/");
pos += 3; pos += 3;
} }

View File

@@ -1,31 +1,32 @@
#include <stddef.h> #include <bfbs_gen_lua.h>
#include <stdint.h> #include <bfbs_gen_nim.h>
#include <string>
#include "flatbuffers/idl.h" // For Parser and generation functions
#include "test_init.h"
#include <memory>
#include <flatbuffers/flatc.h> #include <flatbuffers/flatc.h>
#include "idl_gen_cpp.h" // For C++ generator
#include <idl_gen_csharp.h>
#include <iostream>
#include "flatbuffers/code_generator.h"
#include <idl_gen_binary.h> #include <idl_gen_binary.h>
#include <idl_gen_csharp.h>
#include <idl_gen_dart.h> #include <idl_gen_dart.h>
#include <idl_gen_fbs.h> #include <idl_gen_fbs.h>
#include <idl_gen_go.h> #include <idl_gen_go.h>
#include <idl_gen_java.h> #include <idl_gen_java.h>
#include <idl_gen_json_schema.h> #include <idl_gen_json_schema.h>
#include <idl_gen_kotlin.h> #include <idl_gen_kotlin.h>
#include <idl_gen_kotlin.h>
#include <idl_gen_lobster.h> #include <idl_gen_lobster.h>
#include <bfbs_gen_lua.h>
#include <bfbs_gen_nim.h>
#include <idl_gen_python.h>
#include <idl_gen_php.h> #include <idl_gen_php.h>
#include <idl_gen_python.h>
#include <idl_gen_rust.h> #include <idl_gen_rust.h>
#include <idl_gen_text.h>
#include <idl_gen_swift.h> #include <idl_gen_swift.h>
#include <idl_gen_text.h>
#include <idl_gen_ts.h> #include <idl_gen_ts.h>
#include <stddef.h>
#include <stdint.h>
#include <iostream>
#include <memory>
#include <string>
#include "flatbuffers/code_generator.h"
#include "flatbuffers/idl.h" // For Parser and generation functions
#include "idl_gen_cpp.h" // For C++ generator
#include "test_init.h"
static constexpr size_t kMinInputLength = 1; static constexpr size_t kMinInputLength = 1;
static constexpr size_t kMaxInputLength = 16384; static constexpr size_t kMaxInputLength = 16384;
@@ -98,8 +99,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
if (parser.Parse(parse_input)) { if (parser.Parse(parse_input)) {
parser.Serialize(); parser.Serialize();
const uint8_t* buf = parser.builder_.GetBufferPointer(); const uint8_t* buf = parser.builder_.GetBufferPointer();
flatbuffers::Verifier verifier(buf, flatbuffers::Verifier verifier(buf, parser.builder_.GetSize());
parser.builder_.GetSize());
TEST_EQ(true, reflection::VerifySchemaBuffer(verifier)); TEST_EQ(true, reflection::VerifySchemaBuffer(verifier));
auto root = flatbuffers::GetRoot<flatbuffers::Table>(buf); auto root = flatbuffers::GetRoot<flatbuffers::Table>(buf);
@@ -126,8 +126,10 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
generators.emplace_back(flatbuffers::NewKotlinCodeGenerator()); generators.emplace_back(flatbuffers::NewKotlinCodeGenerator());
generators.emplace_back(flatbuffers::NewKotlinKMPCodeGenerator()); generators.emplace_back(flatbuffers::NewKotlinKMPCodeGenerator());
generators.emplace_back(flatbuffers::NewLobsterCodeGenerator()); generators.emplace_back(flatbuffers::NewLobsterCodeGenerator());
generators.emplace_back(flatbuffers::NewLuaBfbsGenerator(flatbuffers_version)); generators.emplace_back(
generators.emplace_back(flatbuffers::NewNimBfbsGenerator(flatbuffers_version)); flatbuffers::NewLuaBfbsGenerator(flatbuffers_version));
generators.emplace_back(
flatbuffers::NewNimBfbsGenerator(flatbuffers_version));
generators.emplace_back(flatbuffers::NewPythonCodeGenerator()); generators.emplace_back(flatbuffers::NewPythonCodeGenerator());
generators.emplace_back(flatbuffers::NewPhpCodeGenerator()); generators.emplace_back(flatbuffers::NewPhpCodeGenerator());
generators.emplace_back(flatbuffers::NewRustCodeGenerator()); generators.emplace_back(flatbuffers::NewRustCodeGenerator());

View File

@@ -1,6 +1,7 @@
#include <iostream>
#include <assert.h> #include <assert.h>
#include <iostream>
#include "flatbuffers/util.h" #include "flatbuffers/util.h"
extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size); extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size);

View File

@@ -1,4 +1,5 @@
#include <iostream> #include <iostream>
#include "flatbuffers/util.h" #include "flatbuffers/util.h"
extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size); extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size);

View File

@@ -27,10 +27,14 @@ void Matrix::UnPackTo(
(void)_resolver; (void)_resolver;
auto _rows = rows(); auto _rows = rows();
if (_rows) { _o->rows = _rows; } if (_rows) {
_o->rows = _rows;
}
auto _columns = columns(); auto _columns = columns();
if (_columns) { _o->columns = _columns; } if (_columns) {
_o->columns = _columns;
}
auto _values = values(); auto _values = values();
if (_values) { if (_values) {

View File

@@ -771,14 +771,14 @@ void FixedLengthArrayTest() {
// set memory chunk of size ArrayStruct to 1's // set memory chunk of size ArrayStruct to 1's
std::memset(static_cast<void*>(non_zero_memory), 1, arr_size); std::memset(static_cast<void*>(non_zero_memory), 1, arr_size);
// after placement-new it should be all 0's // after placement-new it should be all 0's
#if defined(FLATBUFFERS_MEMORY_LEAK_TRACKING) && \ #if defined(FLATBUFFERS_MEMORY_LEAK_TRACKING) && defined(_MSC_VER) && \
defined(_MSC_VER) && defined(_DEBUG) defined(_DEBUG)
#undef new #undef new
#endif #endif
MyGame::Example::ArrayStruct* ap = MyGame::Example::ArrayStruct* ap =
new (non_zero_memory) MyGame::Example::ArrayStruct; new (non_zero_memory) MyGame::Example::ArrayStruct;
#if defined(FLATBUFFERS_MEMORY_LEAK_TRACKING) && \ #if defined(FLATBUFFERS_MEMORY_LEAK_TRACKING) && defined(_MSC_VER) && \
defined(_MSC_VER) && defined(_DEBUG) defined(_DEBUG)
#define new DEBUG_NEW #define new DEBUG_NEW
#endif #endif
(void)ap; (void)ap;
@@ -925,7 +925,8 @@ void NativeTypeTest() {
src_data.matrix->values = {3, 4}; src_data.matrix->values = {3, 4};
for (int i = 0; i < N; ++i) { for (int i = 0; i < N; ++i) {
src_data.matrices.push_back(std::unique_ptr<Native::Matrix>(new Native::Matrix(1, i))); src_data.matrices.push_back(
std::unique_ptr<Native::Matrix>(new Native::Matrix(1, i)));
std::fill(src_data.matrices[i]->values.begin(), std::fill(src_data.matrices[i]->values.begin(),
src_data.matrices[i]->values.end(), i + 0.5f); src_data.matrices[i]->values.end(), i + 0.5f);
} }