BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-07-01 09:21:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Java] Prevent generation of enum names when underlying type is long (#6781) (#6895)

Browse Source
This commit is contained in:
Fraser Crossman
2021-10-18 23:18:36 +01:00
committed by GitHub
parent e672dabfea
commit f2f9380c86
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/idl_gen_java.cpp
View File

@@ -355,7 +355,7 @@ class JavaGenerator : public BaseGenerator {
code += ";\n"; code += ";\n";
} }
// Generate a generate string table for enum values. // Generate a string table for enum values.
// Problem is, if values are very sparse that could generate really big // Problem is, if values are very sparse that could generate really big
// tables. Ideally in that case we generate a map lookup instead, but for // tables. Ideally in that case we generate a map lookup instead, but for
// the moment we simply don't output a table at all. // the moment we simply don't output a table at all.
@@ -363,7 +363,9 @@ class JavaGenerator : public BaseGenerator {
// Average distance between values above which we consider a table // Average distance between values above which we consider a table
// "too sparse". Change at will. // "too sparse". Change at will.
static const uint64_t kMaxSparseness = 5; static const uint64_t kMaxSparseness = 5;
if (range / static_cast<uint64_t>(enum_def.size()) < kMaxSparseness) { if (range / static_cast<uint64_t>(enum_def.size()) < kMaxSparseness &&
GenTypeBasic(DestinationType(enum_def.underlying_type, false)) !=
"long") {
code += "\n public static final String"; code += "\n public static final String";
code += "[] names = { "; code += "[] names = { ";
auto val = enum_def.Vals().front(); auto val = enum_def.Vals().front();