From f28c2b29364970e23c8ba3d751ca188f8a08c71e Mon Sep 17 00:00:00 2001 From: Advait Jain Date: Thu, 23 Dec 2021 18:31:30 -0800 Subject: [PATCH] Avoid implicit conversion from float to double. (#7003) https://github.com/tensorflow/tflite-micro makes use of flatbuffers with a variety of DSP toolchains. Without the change from this PR, we can get a double-promotion warning with some of these DSP toolchains: ``` flatbuffers/include/flatbuffers/util.h:104:11: error: implicit conversion increases floating-point precision: 'std::numeric_limits::_Ty' (aka 'float') to 'double' [-Werror,-Wdouble-promotion] T eps = std::numeric_limits::epsilon(); ~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` --- include/flatbuffers/util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/flatbuffers/util.h b/include/flatbuffers/util.h index 93a39de17..c0a37b9f6 100644 --- a/include/flatbuffers/util.h +++ b/include/flatbuffers/util.h @@ -95,7 +95,7 @@ template size_t IntToDigitCount(T t) { // Count a single 0 left of the dot for fractional numbers if (-1 < t && t < 1) digit_count++; // Count digits until fractional part - T eps = std::numeric_limits::epsilon(); + T eps = std::numeric_limits::epsilon(); while (t <= (-1 + eps) || (1 - eps) <= t) { t /= 10; digit_count++;