diff --git a/docs/source/Internals.md b/docs/source/Internals.md index 60b813003..e8f453a87 100644 --- a/docs/source/Internals.md +++ b/docs/source/Internals.md @@ -169,7 +169,7 @@ Unions share a lot with enums. Predeclare all data types since circular references between types are allowed (circular references between object are not, though). - MANUALLY_ALIGNED_STRUCT(4) Vec3 { + FLATBUFFERS_MANUALLY_ALIGNED_STRUCT(4) Vec3 { private: float x_; float y_; @@ -183,7 +183,7 @@ Predeclare all data types since circular references between types are allowed float y() const { return flatbuffers::EndianScalar(y_); } float z() const { return flatbuffers::EndianScalar(z_); } }; - STRUCT_END(Vec3, 12); + FLATBUFFERS_STRUCT_END(Vec3, 12); These ugly macros do a couple of things: they turn off any padding the compiler might normally do, since we add padding manually (though none in this example), diff --git a/include/flatbuffers/flatbuffers.h b/include/flatbuffers/flatbuffers.h index 81aa9ac6b..89098c80f 100644 --- a/include/flatbuffers/flatbuffers.h +++ b/include/flatbuffers/flatbuffers.h @@ -2131,17 +2131,17 @@ inline int LookupEnum(const char **names, const char *name) { // clang-format off #if defined(_MSC_VER) - #define MANUALLY_ALIGNED_STRUCT(alignment) \ + #define FLATBUFFERS_MANUALLY_ALIGNED_STRUCT(alignment) \ __pragma(pack(1)); \ struct __declspec(align(alignment)) - #define STRUCT_END(name, size) \ + #define FLATBUFFERS_STRUCT_END(name, size) \ __pragma(pack()); \ static_assert(sizeof(name) == size, "compiler breaks packing rules") #elif defined(__GNUC__) || defined(__clang__) - #define MANUALLY_ALIGNED_STRUCT(alignment) \ + #define FLATBUFFERS_MANUALLY_ALIGNED_STRUCT(alignment) \ _Pragma("pack(1)") \ struct __attribute__((aligned(alignment))) - #define STRUCT_END(name, size) \ + #define FLATBUFFERS_STRUCT_END(name, size) \ _Pragma("pack()") \ static_assert(sizeof(name) == size, "compiler breaks packing rules") #else @@ -2240,7 +2240,7 @@ volatile __attribute__((weak)) const char *flatbuffer_version_string = #endif // !defined(_WIN32) && !defined(__CYGWIN__) -#define DEFINE_BITMASK_OPERATORS(E, T)\ +#define FLATBUFFERS_DEFINE_BITMASK_OPERATORS(E, T)\ inline E operator | (E lhs, E rhs){\ return E(T(lhs) | T(rhs));\ }\ diff --git a/samples/monster_generated.h b/samples/monster_generated.h index 4a7660697..52b00c9a3 100644 --- a/samples/monster_generated.h +++ b/samples/monster_generated.h @@ -170,7 +170,7 @@ MANUALLY_ALIGNED_STRUCT(4) Vec3 FLATBUFFERS_FINAL_CLASS { flatbuffers::WriteScalar(&z_, _z); } }; -STRUCT_END(Vec3, 12); +FLATBUFFERS_STRUCT_END(Vec3, 12); struct MonsterT : public flatbuffers::NativeTable { typedef Monster TableType; diff --git a/src/idl_gen_cpp.cpp b/src/idl_gen_cpp.cpp index 7c041a2f2..917e41d3c 100644 --- a/src/idl_gen_cpp.cpp +++ b/src/idl_gen_cpp.cpp @@ -922,7 +922,7 @@ class CppGenerator : public BaseGenerator { code_ += "};"; if (parser_.opts.scoped_enums && enum_def.attributes.Lookup("bit_flags")) { - code_ += "DEFINE_BITMASK_OPERATORS({{ENUM_NAME}}, {{BASE_TYPE}})"; + code_ += "FLATBUFFERS_DEFINE_BITMASK_OPERATORS({{ENUM_NAME}}, {{BASE_TYPE}})"; } code_ += ""; @@ -2434,7 +2434,7 @@ class CppGenerator : public BaseGenerator { code_.SetValue("STRUCT_NAME", Name(struct_def)); code_ += - "MANUALLY_ALIGNED_STRUCT({{ALIGN}}) " + "FLATBUFFERS_MANUALLY_ALIGNED_STRUCT({{ALIGN}}) " "{{STRUCT_NAME}} FLATBUFFERS_FINAL_CLASS {"; code_ += " private:"; @@ -2576,7 +2576,7 @@ class CppGenerator : public BaseGenerator { code_ += "};"; code_.SetValue("STRUCT_BYTE_SIZE", NumToString(struct_def.bytesize)); - code_ += "STRUCT_END({{STRUCT_NAME}}, {{STRUCT_BYTE_SIZE}});"; + code_ += "FLATBUFFERS_STRUCT_END({{STRUCT_NAME}}, {{STRUCT_BYTE_SIZE}});"; code_ += ""; } diff --git a/tests/monster_test_generated.h b/tests/monster_test_generated.h index fd0f78435..53776b9cd 100644 --- a/tests/monster_test_generated.h +++ b/tests/monster_test_generated.h @@ -247,7 +247,7 @@ MANUALLY_ALIGNED_STRUCT(2) Test FLATBUFFERS_FINAL_CLASS { flatbuffers::WriteScalar(&b_, _b); } }; -STRUCT_END(Test, 4); +FLATBUFFERS_STRUCT_END(Test, 4); MANUALLY_ALIGNED_STRUCT(16) Vec3 FLATBUFFERS_FINAL_CLASS { private: @@ -316,7 +316,7 @@ MANUALLY_ALIGNED_STRUCT(16) Vec3 FLATBUFFERS_FINAL_CLASS { return test3_; } }; -STRUCT_END(Vec3, 32); +FLATBUFFERS_STRUCT_END(Vec3, 32); MANUALLY_ALIGNED_STRUCT(4) Ability FLATBUFFERS_FINAL_CLASS { private: @@ -351,7 +351,7 @@ MANUALLY_ALIGNED_STRUCT(4) Ability FLATBUFFERS_FINAL_CLASS { flatbuffers::WriteScalar(&distance_, _distance); } }; -STRUCT_END(Ability, 8); +FLATBUFFERS_STRUCT_END(Ability, 8); } // namespace Example diff --git a/tests/namespace_test/namespace_test1_generated.h b/tests/namespace_test/namespace_test1_generated.h index 2068d1fc8..7205cf076 100644 --- a/tests/namespace_test/namespace_test1_generated.h +++ b/tests/namespace_test/namespace_test1_generated.h @@ -75,7 +75,7 @@ MANUALLY_ALIGNED_STRUCT(4) StructInNestedNS FLATBUFFERS_FINAL_CLASS { flatbuffers::WriteScalar(&b_, _b); } }; -STRUCT_END(StructInNestedNS, 8); +FLATBUFFERS_STRUCT_END(StructInNestedNS, 8); struct TableInNestedNS FLATBUFFERS_FINAL_CLASS : private flatbuffers::Table { static const flatbuffers::TypeTable *MiniReflectTypeTable() { diff --git a/tests/union_vector/union_vector_generated.h b/tests/union_vector/union_vector_generated.h index 07b17a9c0..b6b20d4b6 100644 --- a/tests/union_vector/union_vector_generated.h +++ b/tests/union_vector/union_vector_generated.h @@ -159,7 +159,7 @@ MANUALLY_ALIGNED_STRUCT(4) Rapunzel FLATBUFFERS_FINAL_CLASS { flatbuffers::WriteScalar(&hair_length_, _hair_length); } }; -STRUCT_END(Rapunzel, 4); +FLATBUFFERS_STRUCT_END(Rapunzel, 4); MANUALLY_ALIGNED_STRUCT(4) BookReader FLATBUFFERS_FINAL_CLASS { private: @@ -179,7 +179,7 @@ MANUALLY_ALIGNED_STRUCT(4) BookReader FLATBUFFERS_FINAL_CLASS { flatbuffers::WriteScalar(&books_read_, _books_read); } }; -STRUCT_END(BookReader, 4); +FLATBUFFERS_STRUCT_END(BookReader, 4); struct AttackerT : public flatbuffers::NativeTable { typedef Attacker TableType;