BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-21 01:57:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

[TS] Fix getFullyQualifiedName codegen for typescript (#7730)

Browse Source 
#7451 caused getFullyQualifiedName to return a name with underscores,
not periods. Because the fully qualified name is a property of
FlatBuffers, not the language being codegen'd for, it should use
periods. Fixes #7564.

Co-authored-by: Derek Bailey <derekbailey@google.com>
This commit is contained in:
James Kuszmaul
2022-12-22 12:59:40 -08:00
committed by GitHub
parent 449d5649d6
commit e43a80c322
54 changed files with 104 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/ts/typescript/object.js
View File

@@ -98,7 +98,7 @@ export class Object_ {
return offset ? (obj || new Schema()).__init(this.bb.__indirect(this.bb_pos + offset), this.bb) : null;
}
static getFullyQualifiedName() {
return 'typescript_Object';
return 'typescript.Object';
}
static startObject(builder) {
builder.startObject(7);

2
tests/ts/typescript/object.ts
View File

@@ -128,7 +128,7 @@ reflect(obj?:Schema):Schema|null {
}
static getFullyQualifiedName():string {
return 'typescript_Object';
return 'typescript.Object';
}
static startObject(builder:flatbuffers.Builder) {