BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-15 00:38:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[TS] Fix getFullyQualifiedName codegen for typescript (#7730)

Browse Source 
#7451 caused getFullyQualifiedName to return a name with underscores,
not periods. Because the fully qualified name is a property of
FlatBuffers, not the language being codegen'd for, it should use
periods. Fixes #7564.

Co-authored-by: Derek Bailey <derekbailey@google.com>
This commit is contained in:
James Kuszmaul
2022-12-22 12:59:40 -08:00
committed by GitHub
parent 449d5649d6
commit e43a80c322
54 changed files with 104 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/ts/reflection_generated.js
View File

@@ -128,7 +128,7 @@ export class Type {
return true;
}
static getFullyQualifiedName() {
return 'reflection_Type';
return 'reflection.Type';
}
static startType(builder) {
builder.startObject(6);
@@ -216,7 +216,7 @@ export class KeyValue {
return offset ? this.bb.__string(this.bb_pos + offset, optionalEncoding) : null;
}
static getFullyQualifiedName() {
return 'reflection_KeyValue';
return 'reflection.KeyValue';
}
static startKeyValue(builder) {
builder.startObject(2);
@@ -311,7 +311,7 @@ export class EnumVal {
return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
}
static getFullyQualifiedName() {
return 'reflection_EnumVal';
return 'reflection.EnumVal';
}
static startEnumVal(builder) {
builder.startObject(6);
@@ -455,7 +455,7 @@ export class Enum {
return offset ? this.bb.__string(this.bb_pos + offset, optionalEncoding) : null;
}
static getFullyQualifiedName() {
return 'reflection_Enum';
return 'reflection.Enum';
}
static startEnum(builder) {
builder.startObject(7);
@@ -712,7 +712,7 @@ export class Field {
return true;
}
static getFullyQualifiedName() {
return 'reflection_Field';
return 'reflection.Field';
}
static startField(builder) {
builder.startObject(13);
@@ -925,7 +925,7 @@ export class Object_ {
return offset ? this.bb.__string(this.bb_pos + offset, optionalEncoding) : null;
}
static getFullyQualifiedName() {
return 'reflection_Object';
return 'reflection.Object';
}
static startObject(builder) {
builder.startObject(8);
@@ -1082,7 +1082,7 @@ export class RPCCall {
return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
}
static getFullyQualifiedName() {
return 'reflection_RPCCall';
return 'reflection.RPCCall';
}
static startRPCCall(builder) {
builder.startObject(5);
@@ -1213,7 +1213,7 @@ export class Service {
return offset ? this.bb.__string(this.bb_pos + offset, optionalEncoding) : null;
}
static getFullyQualifiedName() {
return 'reflection_Service';
return 'reflection.Service';
}
static startService(builder) {
builder.startObject(5);
@@ -1340,7 +1340,7 @@ export class SchemaFile {
return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
}
static getFullyQualifiedName() {
return 'reflection_SchemaFile';
return 'reflection.SchemaFile';
}
static startSchemaFile(builder) {
builder.startObject(2);
@@ -1472,7 +1472,7 @@ export class Schema {
return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
}
static getFullyQualifiedName() {
return 'reflection_Schema';
return 'reflection.Schema';
}
static startSchema(builder) {
builder.startObject(8);