[TS] Fix getFullyQualifiedName codegen for typescript (#7730)

#7451 caused getFullyQualifiedName to return a name with underscores,
not periods. Because the fully qualified name is a property of
FlatBuffers, not the language being codegen'd for, it should use
periods. Fixes #7564.

Co-authored-by: Derek Bailey <derekbailey@google.com>
This commit is contained in:
James Kuszmaul
2022-12-22 12:59:40 -08:00
committed by GitHub
parent 449d5649d6
commit e43a80c322
54 changed files with 104 additions and 83 deletions

View File

@@ -56,7 +56,7 @@ export class EnumVal {
return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
}
static getFullyQualifiedName() {
return 'reflection_EnumVal';
return 'reflection.EnumVal';
}
static startEnumVal(builder) {
builder.startObject(6);

View File

@@ -75,7 +75,7 @@ attributesLength():number {
}
static getFullyQualifiedName():string {
return 'reflection_EnumVal';
return 'reflection.EnumVal';
}
static startEnumVal(builder:flatbuffers.Builder) {

View File

@@ -69,7 +69,7 @@ export class Enum {
return offset ? this.bb.__string(this.bb_pos + offset, optionalEncoding) : null;
}
static getFullyQualifiedName() {
return 'reflection_Enum';
return 'reflection.Enum';
}
static startEnum(builder) {
builder.startObject(7);

View File

@@ -96,7 +96,7 @@ declarationFile(optionalEncoding?:any):string|Uint8Array|null {
}
static getFullyQualifiedName():string {
return 'reflection_Enum';
return 'reflection.Enum';
}
static startEnum(builder:flatbuffers.Builder) {

View File

@@ -155,7 +155,7 @@ export class Field {
return true;
}
static getFullyQualifiedName() {
return 'reflection_Field';
return 'reflection.Field';
}
static startField(builder) {
builder.startObject(13);

View File

@@ -206,7 +206,7 @@ mutate_padding(value:number):boolean {
}
static getFullyQualifiedName():string {
return 'reflection_Field';
return 'reflection.Field';
}
static startField(builder:flatbuffers.Builder) {

View File

@@ -26,7 +26,7 @@ export class KeyValue {
return offset ? this.bb.__string(this.bb_pos + offset, optionalEncoding) : null;
}
static getFullyQualifiedName() {
return 'reflection_KeyValue';
return 'reflection.KeyValue';
}
static startKeyValue(builder) {
builder.startObject(2);

View File

@@ -37,7 +37,7 @@ value(optionalEncoding?:any):string|Uint8Array|null {
}
static getFullyQualifiedName():string {
return 'reflection_KeyValue';
return 'reflection.KeyValue';
}
static startKeyValue(builder:flatbuffers.Builder) {

View File

@@ -88,7 +88,7 @@ export class Object_ {
return offset ? this.bb.__string(this.bb_pos + offset, optionalEncoding) : null;
}
static getFullyQualifiedName() {
return 'reflection_Object';
return 'reflection.Object';
}
static startObject(builder) {
builder.startObject(8);

View File

@@ -122,7 +122,7 @@ declarationFile(optionalEncoding?:any):string|Uint8Array|null {
}
static getFullyQualifiedName():string {
return 'reflection_Object';
return 'reflection.Object';
}
static startObject(builder:flatbuffers.Builder) {

View File

@@ -48,7 +48,7 @@ export class RPCCall {
return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
}
static getFullyQualifiedName() {
return 'reflection_RPCCall';
return 'reflection.RPCCall';
}
static startRPCCall(builder) {
builder.startObject(5);

View File

@@ -64,7 +64,7 @@ documentationLength():number {
}
static getFullyQualifiedName():string {
return 'reflection_RPCCall';
return 'reflection.RPCCall';
}
static startRPCCall(builder:flatbuffers.Builder) {

View File

@@ -35,7 +35,7 @@ export class SchemaFile {
return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
}
static getFullyQualifiedName() {
return 'reflection_SchemaFile';
return 'reflection.SchemaFile';
}
static startSchemaFile(builder) {
builder.startObject(2);

View File

@@ -53,7 +53,7 @@ includedFilenamesLength():number {
}
static getFullyQualifiedName():string {
return 'reflection_SchemaFile';
return 'reflection.SchemaFile';
}
static startSchemaFile(builder:flatbuffers.Builder) {

View File

@@ -85,7 +85,7 @@ export class Schema {
return offset ? this.bb.__vector_len(this.bb_pos + offset) : 0;
}
static getFullyQualifiedName() {
return 'reflection_Schema';
return 'reflection.Schema';
}
static startSchema(builder) {
builder.startObject(8);

View File

@@ -110,7 +110,7 @@ fbsFilesLength():number {
}
static getFullyQualifiedName():string {
return 'reflection_Schema';
return 'reflection.Schema';
}
static startSchema(builder:flatbuffers.Builder) {

View File

@@ -52,7 +52,7 @@ export class Service {
return offset ? this.bb.__string(this.bb_pos + offset, optionalEncoding) : null;
}
static getFullyQualifiedName() {
return 'reflection_Service';
return 'reflection.Service';
}
static startService(builder) {
builder.startObject(5);

View File

@@ -74,7 +74,7 @@ declarationFile(optionalEncoding?:any):string|Uint8Array|null {
}
static getFullyQualifiedName():string {
return 'reflection_Service';
return 'reflection.Service';
}
static startService(builder:flatbuffers.Builder) {

View File

@@ -97,7 +97,7 @@ export class Type {
return true;
}
static getFullyQualifiedName() {
return 'reflection_Type';
return 'reflection.Type';
}
static startType(builder) {
builder.startObject(6);

View File

@@ -126,7 +126,7 @@ mutate_element_size(value:number):boolean {
}
static getFullyQualifiedName():string {
return 'reflection_Type';
return 'reflection.Type';
}
static startType(builder:flatbuffers.Builder) {