BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-28 12:18:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

[TS] Fix getFullyQualifiedName codegen for typescript (#7730)

Browse Source 
#7451 caused getFullyQualifiedName to return a name with underscores,
not periods. Because the fully qualified name is a property of
FlatBuffers, not the language being codegen'd for, it should use
periods. Fixes #7564.

Co-authored-by: Derek Bailey <derekbailey@google.com>
This commit is contained in:
James Kuszmaul
2022-12-22 12:59:40 -08:00
committed by GitHub
parent 449d5649d6
commit e43a80c322
54 changed files with 104 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/ts/my-game/example2/monster.js
View File

@@ -18,7 +18,7 @@ export class Monster {
return (obj || new Monster()).__init(bb.readInt32(bb.position()) + bb.position(), bb);
}
static getFullyQualifiedName() {
return 'MyGame_Example2_Monster';
return 'MyGame.Example2.Monster';
}
static startMonster(builder) {
builder.startObject(0);

2
tests/ts/my-game/example2/monster.ts
View File

@@ -23,7 +23,7 @@ static getSizePrefixedRootAsMonster(bb:flatbuffers.ByteBuffer, obj?:Monster):Mon
}
static getFullyQualifiedName():string {
return 'MyGame_Example2_Monster';
return 'MyGame.Example2.Monster';
}
static startMonster(builder:flatbuffers.Builder) {