BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-25 23:58:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[TS] Fix getFullyQualifiedName codegen for typescript (#7730)

Browse Source 
#7451 caused getFullyQualifiedName to return a name with underscores,
not periods. Because the fully qualified name is a property of
FlatBuffers, not the language being codegen'd for, it should use
periods. Fixes #7564.

Co-authored-by: Derek Bailey <derekbailey@google.com>
This commit is contained in:
James Kuszmaul
2022-12-22 12:59:40 -08:00
committed by GitHub
parent 449d5649d6
commit e43a80c322
54 changed files with 104 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/ts/arrays_test_complex/arrays_test_complex_generated.js
View File

@@ -29,7 +29,7 @@ export class InnerStruct {
return this.bb.readInt64(this.bb_pos + 24);
}
static getFullyQualifiedName() {
return 'MyGame_Example_InnerStruct';
return 'MyGame.Example.InnerStruct';
}
static sizeOf() {
return 32;
@@ -96,7 +96,7 @@ export class OuterStruct {
return this.bb.readFloat64(this.bb_pos + 176 + index * 8);
}
static getFullyQualifiedName() {
return 'MyGame_Example_OuterStruct';
return 'MyGame.Example.OuterStruct';
}
static sizeOf() {
return 208;
@@ -188,7 +188,7 @@ export class NestedStruct {
return this.bb.readInt64(this.bb_pos + 1056 + index * 8);
}
static getFullyQualifiedName() {
return 'MyGame_Example_NestedStruct';
return 'MyGame.Example.NestedStruct';
}
static sizeOf() {
return 1072;
@@ -272,7 +272,7 @@ export class ArrayStruct {
return this.bb.readInt64(this.bb_pos + 2640 + index * 8);
}
static getFullyQualifiedName() {
return 'MyGame_Example_ArrayStruct';
return 'MyGame.Example.ArrayStruct';
}
static sizeOf() {
return 2656;
@@ -365,7 +365,7 @@ export class ArrayTable {
return offset ? (obj || new ArrayStruct()).__init(this.bb_pos + offset, this.bb) : null;
}
static getFullyQualifiedName() {
return 'MyGame_Example_ArrayTable';
return 'MyGame.Example.ArrayTable';
}
static startArrayTable(builder) {
builder.startObject(2);

10
tests/ts/arrays_test_complex/arrays_test_complex_generated.ts
View File

@@ -35,7 +35,7 @@ dUnderscore():bigint {
}
static getFullyQualifiedName():string {
return 'MyGame_Example_InnerStruct';
return 'MyGame.Example.InnerStruct';
}
static sizeOf():number {
@@ -129,7 +129,7 @@ f(index: number):number|null {
}
static getFullyQualifiedName():string {
return 'MyGame_Example_OuterStruct';
return 'MyGame.Example.OuterStruct';
}
static sizeOf():number {
@@ -271,7 +271,7 @@ e(index: number):bigint|null {
}
static getFullyQualifiedName():string {
return 'MyGame_Example_NestedStruct';
return 'MyGame.Example.NestedStruct';
}
static sizeOf():number {
@@ -407,7 +407,7 @@ g(index: number):bigint|null {
}
static getFullyQualifiedName():string {
return 'MyGame_Example_ArrayStruct';
return 'MyGame.Example.ArrayStruct';
}
static sizeOf():number {
@@ -563,7 +563,7 @@ cUnderscore(obj?:ArrayStruct):ArrayStruct|null {
}
static getFullyQualifiedName():string {
return 'MyGame_Example_ArrayTable';
return 'MyGame.Example.ArrayTable';
}
static startArrayTable(builder:flatbuffers.Builder) {