BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-10 07:06:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing namespace qualifier in Pack() (#8967)

Browse Source 
* Fix missing namespace qualifier in Pack() for cross-namespace table references

* Fix missing namespace qualifier in Pack()

* Add cross_namespace_pack_test to Bazel build
This commit is contained in:
tmimmanuel
2026-03-12 02:11:06 +00:00
committed by GitHub
parent 9e3fe5d3f6
commit e35817577c
14 changed files with 111 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/test.cpp
View File

@@ -34,6 +34,7 @@
#include "third_party/absl/container/flat_hash_set.h"
#endif
#include "alignment_test.h"
#include "cross_namespace_pack_test_generated.h"
#include "default_vectors_strings_test.h"
#include "evolution_test.h"
#include "flatbuffers/flatbuffers.h"
@@ -1721,6 +1722,29 @@ static void Offset64Tests() {
#endif
}
// Test that Pack() generates correctly namespace-qualified Create* calls
// when referencing tables from different namespaces. (issue #8948)
void CrossNamespacePackTest() {
// Build a Consumer with a cross-namespace TableWithNative reference.
foo::ConsumerT consumer;
consumer.c1 = std::make_unique<native::TableWithNativeT>();
consumer.c1->value = 42;
// Add a vector element too.
consumer.c2.push_back(std::make_unique<native::TableWithNativeT>());
consumer.c2[0]->value = 99;
// Pack and verify round-trip.
flatbuffers::FlatBufferBuilder fbb;
fbb.Finish(foo::Consumer::Pack(fbb, &consumer));
auto* packed = flatbuffers::GetRoot<foo::Consumer>(fbb.GetBufferPointer());
auto unpacked = packed->UnPack();
TEST_EQ(unpacked->c1->value, 42);
TEST_EQ(unpacked->c2.size(), 1);
TEST_EQ(unpacked->c2[0]->value, 99);
}
int FlatBufferTests(const std::string& tests_data_path) {
// Run our various test suites:
@@ -1838,6 +1862,7 @@ int FlatBufferTests(const std::string& tests_data_path) {
UnionUnderlyingTypeTest();
StructsInHashTableTest();
DefaultVectorsStringsTest();
CrossNamespacePackTest();
return 0;
}
} // namespace