From bbfd12eb11a878a740d81f56fe8b426197a8b4f3 Mon Sep 17 00:00:00 2001
From: Robert <rw@users.noreply.github.com>
Date: Wed, 16 Jan 2019 16:41:02 -0800
Subject: [PATCH] Docker tests for Zend PHP and Mono C#; Python coverage; TODO
 for HHVM PHP (#5125)

* Docker test for Zend PHP 7.3

* hhvm

* move failing hhvm test to TODO zone

* c# mono 5.18 test

* python coverage reports
---
 ...TODO.Dockerfile.testing.php.hhvm_2019_01_16 | 18 ++++++++++++++++++
 .../Dockerfile.testing.csharp.mono_5_18        |  8 ++++++++
 .../languages/Dockerfile.testing.php.zend_7_3  |  8 ++++++++
 .../Dockerfile.testing.python.cpython_2_7_15   |  1 +
 .../Dockerfile.testing.python.cpython_3_7_1    |  1 +
 5 files changed, 36 insertions(+)
 create mode 100644 tests/docker/TODO.Dockerfile.testing.php.hhvm_2019_01_16
 create mode 100644 tests/docker/languages/Dockerfile.testing.csharp.mono_5_18
 create mode 100644 tests/docker/languages/Dockerfile.testing.php.zend_7_3

diff --git a/tests/docker/TODO.Dockerfile.testing.php.hhvm_2019_01_16 b/tests/docker/TODO.Dockerfile.testing.php.hhvm_2019_01_16
new file mode 100644
index 000000000..e5023fa1b
--- /dev/null
+++ b/tests/docker/TODO.Dockerfile.testing.php.hhvm_2019_01_16
@@ -0,0 +1,18 @@
+# This does not pass tests due to the following error:
+#
+# Fatal error: Uncaught exception 'InvalidArgumentException' with message 'Google\FlatBuffers\ByteBuffer::getX() expects parameter 1 by reference, but the call was not annotated with '&'. in /code/php/FlatbufferBuilder.php:971
+# Stack trace:
+# #0 /code/tests/phpTest.php(277): Google\FlatBuffers\FlatbufferBuilder->sizedByteArray()
+# #1 /code/tests/phpTest.php(79): fuzzTest1()
+# #2 /code/tests/phpTest.php(86): main()
+# #3 {main}
+#   thrown in in /code/php/FlatbufferBuilder.php:971
+FROM hhvm/hhvm:2019.01.16 as base
+WORKDIR /code
+ADD . .
+RUN cp flatc_debian_stretch flatc
+WORKDIR /code/tests
+RUN hhvm --version
+RUN hhvm phpTest.php
+RUN ../flatc --php -o php union_vector/union_vector.fbs
+RUN hhvm phpUnionVectorTest.php
diff --git a/tests/docker/languages/Dockerfile.testing.csharp.mono_5_18 b/tests/docker/languages/Dockerfile.testing.csharp.mono_5_18
new file mode 100644
index 000000000..e6ba5504c
--- /dev/null
+++ b/tests/docker/languages/Dockerfile.testing.csharp.mono_5_18
@@ -0,0 +1,8 @@
+FROM mono:5.18 as base
+WORKDIR /code
+ADD . .
+RUN cp flatc_debian_stretch flatc
+WORKDIR /code/tests
+RUN mono --version
+WORKDIR /code/tests/FlatBuffers.Test
+RUN sh NetTest.sh
diff --git a/tests/docker/languages/Dockerfile.testing.php.zend_7_3 b/tests/docker/languages/Dockerfile.testing.php.zend_7_3
new file mode 100644
index 000000000..6cdf43c9c
--- /dev/null
+++ b/tests/docker/languages/Dockerfile.testing.php.zend_7_3
@@ -0,0 +1,8 @@
+FROM php:7.3-cli-stretch as base
+WORKDIR /code
+ADD . .
+RUN cp flatc_debian_stretch flatc
+WORKDIR /code/tests
+RUN php --version
+RUN php phpTest.php
+RUN sh phpUnionVectorTest.sh
diff --git a/tests/docker/languages/Dockerfile.testing.python.cpython_2_7_15 b/tests/docker/languages/Dockerfile.testing.python.cpython_2_7_15
index cb3b3c29c..e68303e39 100644
--- a/tests/docker/languages/Dockerfile.testing.python.cpython_2_7_15
+++ b/tests/docker/languages/Dockerfile.testing.python.cpython_2_7_15
@@ -4,4 +4,5 @@ ADD . .
 RUN cp flatc_debian_stretch flatc
 WORKDIR /code/tests
 RUN python --version
+RUN pip install coverage
 RUN ./PythonTest.sh
diff --git a/tests/docker/languages/Dockerfile.testing.python.cpython_3_7_1 b/tests/docker/languages/Dockerfile.testing.python.cpython_3_7_1
index a3873d9a1..7c2f15c80 100644
--- a/tests/docker/languages/Dockerfile.testing.python.cpython_3_7_1
+++ b/tests/docker/languages/Dockerfile.testing.python.cpython_3_7_1
@@ -4,4 +4,5 @@ ADD . .
 RUN cp flatc_debian_stretch flatc
 WORKDIR /code/tests
 RUN python --version
+RUN pip install coverage
 RUN ./PythonTest.sh