From b7f13cd8e8cc8875a1b55602e83e6ee0067aac0e Mon Sep 17 00:00:00 2001 From: Yasser Shalabi Date: Wed, 27 Jul 2022 01:05:01 +0300 Subject: [PATCH] cpp_generator: comment out unused parameter to avoid warnings (#7381) Presently flatc generates a placeholder for the unused synchronous varient of client-side streaming gRPCs which includes the name of an unused parameter in the method. To avoid warnings, comment out the parameter name (in a manner similar to other gRPCS). --- grpc/src/compiler/cpp_generator.cc | 2 +- tests/monster_test.grpc.fb.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/grpc/src/compiler/cpp_generator.cc b/grpc/src/compiler/cpp_generator.cc index 69dcf59d9..59dcc66d2 100644 --- a/grpc/src/compiler/cpp_generator.cc +++ b/grpc/src/compiler/cpp_generator.cc @@ -648,7 +648,7 @@ void PrintHeaderServerMethodAsync(grpc_generator::Printer *printer, "::grpc::Status $Method$(" "::grpc::ServerContext* /*context*/, " "::grpc::ServerReader< $Request$>* /*reader*/, " - "$Response$* response) final override {\n" + "$Response$* /*response*/) final override {\n" " abort();\n" " return ::grpc::Status(::grpc::StatusCode::UNIMPLEMENTED, \"\");\n" "}\n"); diff --git a/tests/monster_test.grpc.fb.h b/tests/monster_test.grpc.fb.h index 4d726e10d..e3f3037ba 100644 --- a/tests/monster_test.grpc.fb.h +++ b/tests/monster_test.grpc.fb.h @@ -201,7 +201,7 @@ class MonsterStorage final { BaseClassMustBeDerivedFromService(this); } // disable synchronous version of this method - ::grpc::Status GetMaxHitPoint(::grpc::ServerContext* /*context*/, ::grpc::ServerReader< flatbuffers::grpc::Message>* /*reader*/, flatbuffers::grpc::Message* response) final override { + ::grpc::Status GetMaxHitPoint(::grpc::ServerContext* /*context*/, ::grpc::ServerReader< flatbuffers::grpc::Message>* /*reader*/, flatbuffers::grpc::Message* /*response*/) final override { abort(); return ::grpc::Status(::grpc::StatusCode::UNIMPLEMENTED, ""); }