BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-28 14:10:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests/test.cpp contains a couple of tests that are only executed (#7571)

Browse Source 
on a subset of platforms. The test calls are guarded via #ifndef
FLATBUFFERS_NO_FILE_TEST.

Embedders of flatbuffers that rely on -Werror,-Wunused-function
compiler flags (like chromium) complain about the exsitence of these
tests in the anonymous namespace.

This CL guards the test definitions as well (not just the test
calls).

Co-authored-by: Dominic Battre <battre@chromium.org>
Co-authored-by: Derek Bailey <derekbailey@google.com>
This commit is contained in:
Dominic Battre
2022-10-18 21:37:06 +02:00
committed by GitHub
parent 04cd037ba2
commit acc6a20d39
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/test.cpp
View File

@@ -83,6 +83,8 @@ void TriviallyCopyableTest() {
// clang-format on // clang-format on
} }
// Guard against -Wunused-function on platforms without file tests.
#ifndef FLATBUFFERS_NO_FILE_TESTS
void GenerateTableTextTest(const std::string &tests_data_path) { void GenerateTableTextTest(const std::string &tests_data_path) {
std::string schemafile; std::string schemafile;
std::string jsonfile; std::string jsonfile;
@@ -377,6 +379,7 @@ void UnionVectorTest(const std::string &tests_data_path) {
true); true);
TEST_EQ(parser2.Parse("{a_type:Bool,a:{b:true}}"), true); TEST_EQ(parser2.Parse("{a_type:Bool,a:{b:true}}"), true);
} }
#endif
void EndianSwapTest() { void EndianSwapTest() {
TEST_EQ(flatbuffers::EndianSwap(static_cast<int16_t>(0x1234)), 0x3412); TEST_EQ(flatbuffers::EndianSwap(static_cast<int16_t>(0x1234)), 0x3412);
@@ -841,6 +844,8 @@ void NativeTypeTest() {
} }
} }
// Guard against -Wunused-function on platforms without file tests.
#ifndef FLATBUFFERS_NO_FILE_TESTS
// VS10 does not support typed enums, exclude from tests // VS10 does not support typed enums, exclude from tests
#if !defined(_MSC_VER) || _MSC_VER >= 1700 #if !defined(_MSC_VER) || _MSC_VER >= 1700
void FixedLengthArrayJsonTest(const std::string &tests_data_path, bool binary) { void FixedLengthArrayJsonTest(const std::string &tests_data_path, bool binary) {
@@ -1031,6 +1036,7 @@ void TestEmbeddedBinarySchema(const std::string &tests_data_path) {
parserOrg.builder_.GetSize()), parserOrg.builder_.GetSize()),
0); 0);
} }
#endif
void NestedVerifierTest() { void NestedVerifierTest() {
// Create a nested monster. // Create a nested monster.