From a2c913aec30778699dda8862ed14e09d235ebb83 Mon Sep 17 00:00:00 2001 From: Derek Bailey Date: Tue, 12 Apr 2022 16:22:39 -0700 Subject: [PATCH] Add -Wnon-virtual-dtor --- CMakeLists.txt | 1 + src/namer.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 6e004e98b..10c393af6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -361,6 +361,7 @@ else() -Wextra-semi -Werror=shadow -fsigned-char + -Wnon-virtual-dtor $<$: $<$,3.8>: diff --git a/src/namer.h b/src/namer.h index 438c5eee8..ff0039406 100644 --- a/src/namer.h +++ b/src/namer.h @@ -108,6 +108,8 @@ class Namer { Namer(Config config, std::set keywords) : config_(config), keywords_(std::move(keywords)) {} + virtual ~Namer() {} + template std::string Method(const T &s) const { return Method(s.name); }