BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-11 07:27:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Performance improvement to generated+supporting PHP (#5080)

Browse Source 
By avoiding redundant alignment+alloc checks (startVector does prep) and virtual calls
(by making the class final) in inner loops.
This commit is contained in:
Peter Dillinger
2018-12-20 16:10:20 -08:00
committed by Wouter van Oortmerssen
parent cb99116aca
commit 87704e987e
5 changed files with 35 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/union_vector/Movie.php
View File

@@ -154,7 +154,7 @@ class Movie extends Table
{
$builder->startVector(1, count($data), 1);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addByte($data[$i]);
$builder->putByte($data[$i]);
}
return $builder->endVector();
}
@@ -188,7 +188,7 @@ class Movie extends Table
{
$builder->startVector(4, count($data), 4);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addOffset($data[$i]);
$builder->putOffset($data[$i]);
}
return $builder->endVector();
}