BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-04 20:48:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Performance improvement to generated+supporting PHP (#5080)

Browse Source 
By avoiding redundant alignment+alloc checks (startVector does prep) and virtual calls
(by making the class final) in inner loops.
This commit is contained in:
Peter Dillinger
2018-12-20 16:10:20 -08:00
committed by Wouter van Oortmerssen
parent cb99116aca
commit 87704e987e
5 changed files with 35 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tests/MyGame/Example/Monster.php
View File

@@ -793,7 +793,7 @@ class Monster extends Table
{
$builder->startVector(1, count($data), 1);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addByte($data[$i]);
$builder->putByte($data[$i]);
}
return $builder->endVector();
}
@@ -852,7 +852,7 @@ class Monster extends Table
{
$builder->startVector(4, count($data), 2);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addOffset($data[$i]);
$builder->putOffset($data[$i]);
}
return $builder->endVector();
}
@@ -886,7 +886,7 @@ class Monster extends Table
{
$builder->startVector(4, count($data), 4);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addOffset($data[$i]);
$builder->putOffset($data[$i]);
}
return $builder->endVector();
}
@@ -920,7 +920,7 @@ class Monster extends Table
{
$builder->startVector(4, count($data), 4);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addOffset($data[$i]);
$builder->putOffset($data[$i]);
}
return $builder->endVector();
}
@@ -964,7 +964,7 @@ class Monster extends Table
{
$builder->startVector(1, count($data), 1);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addByte($data[$i]);
$builder->putByte($data[$i]);
}
return $builder->endVector();
}
@@ -1098,7 +1098,7 @@ class Monster extends Table
{
$builder->startVector(1, count($data), 1);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addBool($data[$i]);
$builder->putBool($data[$i]);
}
return $builder->endVector();
}
@@ -1162,7 +1162,7 @@ class Monster extends Table
{
$builder->startVector(4, count($data), 4);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addOffset($data[$i]);
$builder->putOffset($data[$i]);
}
return $builder->endVector();
}
@@ -1196,7 +1196,7 @@ class Monster extends Table
{
$builder->startVector(8, count($data), 4);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addOffset($data[$i]);
$builder->putOffset($data[$i]);
}
return $builder->endVector();
}
@@ -1230,7 +1230,7 @@ class Monster extends Table
{
$builder->startVector(1, count($data), 1);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addByte($data[$i]);
$builder->putByte($data[$i]);
}
return $builder->endVector();
}
@@ -1264,7 +1264,7 @@ class Monster extends Table
{
$builder->startVector(4, count($data), 2);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addOffset($data[$i]);
$builder->putOffset($data[$i]);
}
return $builder->endVector();
}
@@ -1298,7 +1298,7 @@ class Monster extends Table
{
$builder->startVector(8, count($data), 8);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addLong($data[$i]);
$builder->putLong($data[$i]);
}
return $builder->endVector();
}
@@ -1332,7 +1332,7 @@ class Monster extends Table
{
$builder->startVector(8, count($data), 8);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addDouble($data[$i]);
$builder->putDouble($data[$i]);
}
return $builder->endVector();
}
@@ -1376,7 +1376,7 @@ class Monster extends Table
{
$builder->startVector(4, count($data), 4);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addOffset($data[$i]);
$builder->putOffset($data[$i]);
}
return $builder->endVector();
}
@@ -1420,7 +1420,7 @@ class Monster extends Table
{
$builder->startVector(8, count($data), 8);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addUlong($data[$i]);
$builder->putUlong($data[$i]);
}
return $builder->endVector();
}
@@ -1454,7 +1454,7 @@ class Monster extends Table
{
$builder->startVector(4, count($data), 4);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addOffset($data[$i]);
$builder->putOffset($data[$i]);
}
return $builder->endVector();
}
@@ -1498,7 +1498,7 @@ class Monster extends Table
{
$builder->startVector(8, count($data), 8);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addUlong($data[$i]);
$builder->putUlong($data[$i]);
}
return $builder->endVector();
}
@@ -1542,7 +1542,7 @@ class Monster extends Table
{
$builder->startVector(8, count($data), 8);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addUlong($data[$i]);
$builder->putUlong($data[$i]);
}
return $builder->endVector();
}
@@ -1606,7 +1606,7 @@ class Monster extends Table
{
$builder->startVector(1, count($data), 1);
for ($i = count($data) - 1; $i >= 0; $i--) {
$builder->addSbyte($data[$i]);
$builder->putSbyte($data[$i]);
}
return $builder->endVector();
}