BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-29 02:40:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing const on Reference::As<> (#4975)

Browse Source 
Reference::As<> was needlessly mutable wich made them
less safe and harder to use
This commit is contained in:
cor3ntin
2018-10-08 21:52:01 +02:00
committed by Wouter van Oortmerssen
parent 569492e890
commit 7c3c027295
1 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
include/flatbuffers/flexbuffers.h
View File

@@ -591,7 +591,7 @@ class Reference {
} }
} }
template<typename T> T As(); template<typename T> T As() const;
// Experimental: Mutation functions. // Experimental: Mutation functions.
// These allow scalars in an already created buffer to be updated in-place. // These allow scalars in an already created buffer to be updated in-place.
@@ -704,35 +704,35 @@ class Reference {
}; };
// Template specialization for As(). // Template specialization for As().
template<> inline bool Reference::As<bool>() { return AsBool(); } template<> inline bool Reference::As<bool>() const { return AsBool(); }
template<> inline int8_t Reference::As<int8_t>() { return AsInt8(); } template<> inline int8_t Reference::As<int8_t>() const { return AsInt8(); }
template<> inline int16_t Reference::As<int16_t>() { return AsInt16(); } template<> inline int16_t Reference::As<int16_t>() const { return AsInt16(); }
template<> inline int32_t Reference::As<int32_t>() { return AsInt32(); } template<> inline int32_t Reference::As<int32_t>() const { return AsInt32(); }
template<> inline int64_t Reference::As<int64_t>() { return AsInt64(); } template<> inline int64_t Reference::As<int64_t>() const { return AsInt64(); }
template<> inline uint8_t Reference::As<uint8_t>() { return AsUInt8(); } template<> inline uint8_t Reference::As<uint8_t>() const { return AsUInt8(); }
template<> inline uint16_t Reference::As<uint16_t>() { return AsUInt16(); } template<> inline uint16_t Reference::As<uint16_t>() const { return AsUInt16(); }
template<> inline uint32_t Reference::As<uint32_t>() { return AsUInt32(); } template<> inline uint32_t Reference::As<uint32_t>() const { return AsUInt32(); }
template<> inline uint64_t Reference::As<uint64_t>() { return AsUInt64(); } template<> inline uint64_t Reference::As<uint64_t>() const { return AsUInt64(); }
template<> inline double Reference::As<double>() { return AsDouble(); } template<> inline double Reference::As<double>() const { return AsDouble(); }
template<> inline float Reference::As<float>() { return AsFloat(); } template<> inline float Reference::As<float>() const { return AsFloat(); }
template<> inline String Reference::As<String>() { return AsString(); } template<> inline String Reference::As<String>() const { return AsString(); }
template<> inline std::string Reference::As<std::string>() { template<> inline std::string Reference::As<std::string>() const {
return AsString().str(); return AsString().str();
} }
template<> inline Blob Reference::As<Blob>() { return AsBlob(); } template<> inline Blob Reference::As<Blob>() const { return AsBlob(); }
template<> inline Vector Reference::As<Vector>() { return AsVector(); } template<> inline Vector Reference::As<Vector>() const { return AsVector(); }
template<> inline TypedVector Reference::As<TypedVector>() { template<> inline TypedVector Reference::As<TypedVector>() const {
return AsTypedVector(); return AsTypedVector();
} }
template<> inline FixedTypedVector Reference::As<FixedTypedVector>() { template<> inline FixedTypedVector Reference::As<FixedTypedVector>() const {
return AsFixedTypedVector(); return AsFixedTypedVector();
} }
template<> inline Map Reference::As<Map>() { return AsMap(); } template<> inline Map Reference::As<Map>() const { return AsMap(); }
inline uint8_t PackedType(BitWidth bit_width, Type type) { inline uint8_t PackedType(BitWidth bit_width, Type type) {
return static_cast<uint8_t>(bit_width | (type << 2)); return static_cast<uint8_t>(bit_width | (type << 2));