BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-23 05:30:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix namespaced struct/field name collision detection (#5540) (#5545)

Browse Source 
Changes the use of `LookupStruct` to `LookupCreateStruct` in
`ParseField` to also detect when collisions happen in namespaces.
This commit is contained in:
Jack Zhou
2019-09-30 14:50:03 -04:00
committed by Wouter van Oortmerssen
parent cfb4ecf6f0
commit 69d3fec488
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/idl_parser.cpp
View File

@@ -677,7 +677,7 @@ CheckedError Parser::AddField(StructDef &struct_def, const std::string &name,
CheckedError Parser::ParseField(StructDef &struct_def) { CheckedError Parser::ParseField(StructDef &struct_def) {
std::string name = attribute_; std::string name = attribute_;
if (LookupStruct(name)) if (LookupCreateStruct(name, false, false))
return Error("field name can not be the same as table/struct name"); return Error("field name can not be the same as table/struct name");
std::vector<std::string> dc = doc_comment_; std::vector<std::string> dc = doc_comment_;