mirror of
https://github.com/google/flatbuffers.git
synced 2026-06-22 18:38:52 +00:00
Add FlatBufferBuilder move semantics tests to the main test suite (#4902)
* Add FlatBufferBuilder move semantics tests to main Do not eagerly delete/reset allocators in release and release_raw functions Update android, vs2010 build files New tests for various types of FlatBufferBuilders and move semantics * Improve test failure output with function names
This commit is contained in:
Sumant Tambe
committed by
Wouter van Oortmerssen
Wouter van Oortmerssen
parent
b1a925dfc2
commit
49fed8c4f6
@@ -1,35 +1,10 @@
|
||||
#include "flatbuffers/grpc.h"
|
||||
#include "monster_test_generated.h"
|
||||
#include "test_assert.h"
|
||||
#include "test_builder.h"
|
||||
|
||||
static int builder_test_error = 0;
|
||||
|
||||
#define test_assert(condition) do { \
|
||||
if(!(condition)) { \
|
||||
fprintf(stderr, "%s:%d: %s failed.\n", __FILE__, __LINE__, #condition);\
|
||||
builder_test_error = 1;\
|
||||
} \
|
||||
} while(0)
|
||||
|
||||
using namespace MyGame::Example;
|
||||
|
||||
const std::string m1_name = "Cyberdemon";
|
||||
const Color m1_color = Color_Red;
|
||||
const std::string m2_name = "Imp";
|
||||
const Color m2_color = Color_Green;
|
||||
|
||||
flatbuffers::Offset<Monster> populate1(flatbuffers::FlatBufferBuilder &builder) {
|
||||
auto name_offset = builder.CreateString(m1_name);
|
||||
return CreateMonster(builder, nullptr, 0, 0, name_offset, 0, m1_color);
|
||||
}
|
||||
|
||||
flatbuffers::Offset<Monster> populate2(flatbuffers::FlatBufferBuilder &builder) {
|
||||
auto name_offset = builder.CreateString(m2_name);
|
||||
return CreateMonster(builder, nullptr, 0, 0, name_offset, 0, m2_color);
|
||||
}
|
||||
|
||||
bool release_n_verify(flatbuffers::FlatBufferBuilder &fbb, const std::string &expected_name, Color color) {
|
||||
flatbuffers::DetachedBuffer buf = fbb.Release();
|
||||
const Monster *monster = flatbuffers::GetRoot<Monster>(buf.data());
|
||||
bool verify(flatbuffers::grpc::Message<Monster> &msg, const std::string &expected_name, Color color) {
|
||||
const Monster *monster = msg.GetRoot();
|
||||
return (monster->name()->str() == expected_name) && (monster->color() == color);
|
||||
}
|
||||
|
||||
@@ -39,121 +14,175 @@ bool release_n_verify(flatbuffers::grpc::MessageBuilder &mbb, const std::string
|
||||
return (monster->name()->str() == expected_name) && (monster->color() == color);
|
||||
}
|
||||
|
||||
struct OwnedAllocator : public flatbuffers::DefaultAllocator {};
|
||||
template <>
|
||||
struct BuilderReuseTests<flatbuffers::grpc::MessageBuilder> {
|
||||
static void builder_reusable_after_release_message_test(TestSelector selector) {
|
||||
if (!selector.count(REUSABLE_AFTER_RELEASE_MESSAGE)) {
|
||||
return;
|
||||
}
|
||||
|
||||
struct TestHeapMessageBuilder : public flatbuffers::FlatBufferBuilder {
|
||||
TestHeapMessageBuilder()
|
||||
: flatbuffers::FlatBufferBuilder(2048, new OwnedAllocator(), true) {}
|
||||
};
|
||||
|
||||
template <class Builder>
|
||||
struct BuilderTests {
|
||||
static void empty_builder_movector_test() {
|
||||
Builder b1;
|
||||
size_t b1_size = b1.GetSize();
|
||||
Builder b2(std::move(b1));
|
||||
size_t b2_size = b2.GetSize();
|
||||
test_assert(b1_size == 0);
|
||||
test_assert(b1_size == b2_size);
|
||||
flatbuffers::grpc::MessageBuilder b1;
|
||||
std::vector<flatbuffers::grpc::Message<Monster>> buffers;
|
||||
for (int i = 0; i < 5; ++i) {
|
||||
auto root_offset1 = populate1(b1);
|
||||
b1.Finish(root_offset1);
|
||||
buffers.push_back(b1.ReleaseMessage<Monster>());
|
||||
TEST_ASSERT_FUNC(verify(buffers[i], m1_name, m1_color));
|
||||
}
|
||||
}
|
||||
|
||||
static void nonempty_builder_movector_test() {
|
||||
Builder b1;
|
||||
populate1(b1);
|
||||
size_t b1_size = b1.GetSize();
|
||||
Builder b2(std::move(b1));
|
||||
test_assert(b1_size == b2.GetSize());
|
||||
test_assert(0 == b1.GetSize());
|
||||
static void builder_reusable_after_release_test(TestSelector selector) {
|
||||
if (!selector.count(REUSABLE_AFTER_RELEASE)) {
|
||||
return;
|
||||
}
|
||||
|
||||
// FIXME: Populate-Release loop fails assert(GRPC_SLICE_IS_EMPTY(slice_)).
|
||||
|
||||
flatbuffers::grpc::MessageBuilder b1;
|
||||
std::vector<flatbuffers::DetachedBuffer> buffers;
|
||||
for (int i = 0; i < 5; ++i) {
|
||||
auto root_offset1 = populate1(b1);
|
||||
b1.Finish(root_offset1);
|
||||
buffers.push_back(b1.Release());
|
||||
TEST_ASSERT_FUNC(verify(buffers[i], m1_name, m1_color));
|
||||
}
|
||||
}
|
||||
|
||||
static void builder_movector_before_finish_test() {
|
||||
Builder b1;
|
||||
auto root_offset1 = populate1(b1);
|
||||
Builder b2(std::move(b1));
|
||||
b2.Finish(root_offset1);
|
||||
test_assert(release_n_verify(b2, m1_name, m1_color));
|
||||
test_assert(0 == b1.GetSize());
|
||||
static void builder_reusable_after_releaseraw_test(TestSelector selector) {
|
||||
if (!selector.count(REUSABLE_AFTER_RELEASE_RAW)) {
|
||||
return;
|
||||
}
|
||||
|
||||
flatbuffers::grpc::MessageBuilder b1;
|
||||
for (int i = 0; i < 5; ++i) {
|
||||
auto root_offset1 = populate1(b1);
|
||||
b1.Finish(root_offset1);
|
||||
size_t size, offset;
|
||||
grpc_slice slice;
|
||||
const uint8_t *buf = b1.ReleaseRaw(size, offset, slice);
|
||||
TEST_ASSERT_FUNC(verify(buf, offset, m1_name, m1_color));
|
||||
grpc_slice_unref(slice);
|
||||
}
|
||||
}
|
||||
|
||||
static void builder_movector_after_finish_test() {
|
||||
Builder b1;
|
||||
auto root_offset1 = populate1(b1);
|
||||
b1.Finish(root_offset1);
|
||||
Builder b2(std::move(b1));
|
||||
test_assert(release_n_verify(b2, m1_name, m1_color));
|
||||
test_assert(0 == b1.GetSize());
|
||||
static void builder_reusable_after_release_and_move_assign_test(TestSelector selector) {
|
||||
if (!selector.count(REUSABLE_AFTER_RELEASE_AND_MOVE_ASSIGN)) {
|
||||
return;
|
||||
}
|
||||
|
||||
// FIXME: Release-move_assign loop fails assert(p == GRPC_SLICE_START_PTR(slice_)).
|
||||
|
||||
flatbuffers::grpc::MessageBuilder b1;
|
||||
std::vector<flatbuffers::DetachedBuffer> buffers;
|
||||
|
||||
for (int i = 0; i < 1; ++i) {
|
||||
auto root_offset1 = populate1(b1);
|
||||
b1.Finish(root_offset1);
|
||||
buffers.push_back(b1.Release());
|
||||
TEST_ASSERT_FUNC(verify(buffers[i], m1_name, m1_color));
|
||||
|
||||
// bring b1 back to life.
|
||||
flatbuffers::grpc::MessageBuilder b2;
|
||||
b1 = std::move(b2);
|
||||
TEST_EQ_FUNC(b1.GetSize(), 0);
|
||||
TEST_EQ_FUNC(b2.GetSize(), 0);
|
||||
}
|
||||
}
|
||||
|
||||
static void builder_move_assign_before_finish_test() {
|
||||
Builder b1;
|
||||
auto root_offset1 = populate1(b1);
|
||||
Builder b2;
|
||||
populate2(b2);
|
||||
b2 = std::move(b1);
|
||||
b2.Finish(root_offset1);
|
||||
test_assert(release_n_verify(b2, m1_name, m1_color));
|
||||
test_assert(0 == b1.GetSize());
|
||||
static void builder_reusable_after_release_message_and_move_assign_test(TestSelector selector) {
|
||||
if (!selector.count(REUSABLE_AFTER_RELEASE_MESSAGE_AND_MOVE_ASSIGN)) {
|
||||
return;
|
||||
}
|
||||
|
||||
flatbuffers::grpc::MessageBuilder b1;
|
||||
std::vector<flatbuffers::grpc::Message<Monster>> buffers;
|
||||
|
||||
for (int i = 0; i < 5; ++i) {
|
||||
auto root_offset1 = populate1(b1);
|
||||
b1.Finish(root_offset1);
|
||||
buffers.push_back(b1.ReleaseMessage<Monster>());
|
||||
TEST_ASSERT_FUNC(verify(buffers[i], m1_name, m1_color));
|
||||
|
||||
// bring b1 back to life.
|
||||
flatbuffers::grpc::MessageBuilder b2;
|
||||
b1 = std::move(b2);
|
||||
TEST_EQ_FUNC(b1.GetSize(), 0);
|
||||
TEST_EQ_FUNC(b2.GetSize(), 0);
|
||||
}
|
||||
}
|
||||
|
||||
static void builder_move_assign_after_finish_test() {
|
||||
Builder b1;
|
||||
auto root_offset1 = populate1(b1);
|
||||
b1.Finish(root_offset1);
|
||||
Builder b2;
|
||||
auto root_offset2 = populate2(b2);
|
||||
b2.Finish(root_offset2);
|
||||
b2 = std::move(b1);
|
||||
test_assert(release_n_verify(b2, m1_name, m1_color));
|
||||
test_assert(0 == b1.GetSize());
|
||||
static void builder_reusable_after_releaseraw_and_move_assign_test(TestSelector selector) {
|
||||
if (!selector.count(REUSABLE_AFTER_RELEASE_RAW_AND_MOVE_ASSIGN)) {
|
||||
return;
|
||||
}
|
||||
|
||||
flatbuffers::grpc::MessageBuilder b1;
|
||||
for (int i = 0; i < 5; ++i) {
|
||||
auto root_offset1 = populate1(b1);
|
||||
b1.Finish(root_offset1);
|
||||
size_t size, offset;
|
||||
grpc_slice slice = grpc_empty_slice();
|
||||
const uint8_t *buf = b1.ReleaseRaw(size, offset, slice);
|
||||
TEST_ASSERT_FUNC(verify(buf, offset, m1_name, m1_color));
|
||||
grpc_slice_unref(slice);
|
||||
|
||||
flatbuffers::grpc::MessageBuilder b2;
|
||||
b1 = std::move(b2);
|
||||
TEST_EQ_FUNC(b1.GetSize(), 0);
|
||||
TEST_EQ_FUNC(b2.GetSize(), 0);
|
||||
}
|
||||
}
|
||||
|
||||
static void builder_swap_before_finish_test() {
|
||||
Builder b1;
|
||||
auto root_offset1 = populate1(b1);
|
||||
auto size1 = b1.GetSize();
|
||||
Builder b2;
|
||||
auto root_offset2 = populate2(b2);
|
||||
auto size2 = b2.GetSize();
|
||||
b1.Swap(b2);
|
||||
b1.Finish(root_offset2);
|
||||
b2.Finish(root_offset1);
|
||||
test_assert(b1.GetSize() > size2);
|
||||
test_assert(b2.GetSize() > size1);
|
||||
test_assert(release_n_verify(b1, m2_name, m2_color));
|
||||
test_assert(release_n_verify(b2, m1_name, m1_color));
|
||||
}
|
||||
|
||||
static void builder_swap_after_finish_test() {
|
||||
Builder b1;
|
||||
auto root_offset1 = populate1(b1);
|
||||
b1.Finish(root_offset1);
|
||||
auto size1 = b1.GetSize();
|
||||
Builder b2;
|
||||
auto root_offset2 = populate2(b2);
|
||||
b2.Finish(root_offset2);
|
||||
auto size2 = b2.GetSize();
|
||||
b1.Swap(b2);
|
||||
test_assert(b1.GetSize() == size2);
|
||||
test_assert(b2.GetSize() == size1);
|
||||
test_assert(release_n_verify(b1, m2_name, m2_color));
|
||||
test_assert(release_n_verify(b2, m1_name, m1_color));
|
||||
}
|
||||
|
||||
static void all_tests() {
|
||||
empty_builder_movector_test();
|
||||
nonempty_builder_movector_test();
|
||||
builder_movector_before_finish_test();
|
||||
builder_movector_after_finish_test();
|
||||
builder_move_assign_before_finish_test();
|
||||
builder_move_assign_after_finish_test();
|
||||
builder_swap_before_finish_test();
|
||||
builder_swap_after_finish_test();
|
||||
static void run_tests(TestSelector selector) {
|
||||
builder_reusable_after_release_test(selector);
|
||||
builder_reusable_after_release_message_test(selector);
|
||||
builder_reusable_after_releaseraw_test(selector);
|
||||
builder_reusable_after_release_and_move_assign_test(selector);
|
||||
builder_reusable_after_releaseraw_and_move_assign_test(selector);
|
||||
builder_reusable_after_release_message_and_move_assign_test(selector);
|
||||
}
|
||||
};
|
||||
|
||||
int builder_tests() {
|
||||
BuilderTests<flatbuffers::grpc::MessageBuilder>::all_tests();
|
||||
BuilderTests<flatbuffers::FlatBufferBuilder>::all_tests();
|
||||
BuilderTests<TestHeapMessageBuilder>::all_tests();
|
||||
return builder_test_error;
|
||||
void slice_allocator_tests() {
|
||||
// move-construct no-delete test
|
||||
{
|
||||
size_t size = 2048;
|
||||
flatbuffers::grpc::SliceAllocator sa1;
|
||||
uint8_t *buf = sa1.allocate(size);
|
||||
TEST_ASSERT_FUNC(buf != 0);
|
||||
buf[0] = 100;
|
||||
buf[size-1] = 200;
|
||||
flatbuffers::grpc::SliceAllocator sa2(std::move(sa1));
|
||||
// buf should be deleted after move-construct
|
||||
TEST_EQ_FUNC(buf[0], 100);
|
||||
TEST_EQ_FUNC(buf[size-1], 200);
|
||||
// buf is freed here
|
||||
}
|
||||
|
||||
// move-assign test
|
||||
{
|
||||
flatbuffers::grpc::SliceAllocator sa1, sa2;
|
||||
uint8_t *buf = sa1.allocate(2048);
|
||||
sa1 = std::move(sa2);
|
||||
// sa1 deletes previously allocated memory in move-assign.
|
||||
// So buf is no longer usable here.
|
||||
TEST_ASSERT_FUNC(buf != 0);
|
||||
}
|
||||
}
|
||||
|
||||
void message_builder_tests() {
|
||||
slice_allocator_tests();
|
||||
BuilderTests<flatbuffers::grpc::MessageBuilder>::all_tests();
|
||||
|
||||
BuilderReuseTestSelector tests[6] = {
|
||||
// REUSABLE_AFTER_RELEASE, // Assertion failed: (GRPC_SLICE_IS_EMPTY(slice_))
|
||||
// REUSABLE_AFTER_RELEASE_AND_MOVE_ASSIGN, // Assertion failed: (p == GRPC_SLICE_START_PTR(slice_)
|
||||
|
||||
REUSABLE_AFTER_RELEASE_RAW,
|
||||
REUSABLE_AFTER_RELEASE_MESSAGE,
|
||||
REUSABLE_AFTER_RELEASE_MESSAGE_AND_MOVE_ASSIGN,
|
||||
REUSABLE_AFTER_RELEASE_RAW_AND_MOVE_ASSIGN
|
||||
};
|
||||
|
||||
BuilderReuseTests<flatbuffers::grpc::MessageBuilder>::run_tests(TestSelector(tests, tests+6));
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user