BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-10 15:16:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

[C++, Java, C#, TypeScript, JavaScript] Skip generation of mutable union types (#5599)

Browse Source 
* Skip generation of mutable union types

* Removed C# and Java unit tests that mutated a Union type
This commit is contained in:
Derek Bailey
2019-11-04 14:54:44 -08:00
committed by Wouter van Oortmerssen
parent 7b38aa71e6
commit 46ae3f80a6
17 changed files with 64 additions and 209 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/idl_gen_js_ts.cpp
View File

@@ -1015,7 +1015,7 @@ class JsTsGenerator : public BaseGenerator {
}
// Adds the mutable scalar value to the output
if (IsScalar(field.value.type.base_type) && parser.opts.mutable_buffer) {
if (IsScalar(field.value.type.base_type) && parser.opts.mutable_buffer && !IsUnion(field.value.type)) {
std::string annotations = GenTypeAnnotation(
kParam, GenTypeName(field.value.type, true), "value");
GenDocComment(