From 40758674b18ab4aa0800ff6883fbe5a2fd7ea728 Mon Sep 17 00:00:00 2001 From: Ben Beasley Date: Tue, 10 Jan 2023 14:36:39 -0500 Subject: [PATCH] Fix some identity/equality confusion in Python tests (#7768) Comparing short strings, small integers, and Booleans by identity (memory address) can work due to optimizations in the Python interpreter, but it is neither formally correct nor reliable. Use equality comparisons instead. Co-authored-by: Derek Bailey --- tests/py_test.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/py_test.py b/tests/py_test.py index 0947adfa3..dc7b734b5 100644 --- a/tests/py_test.py +++ b/tests/py_test.py @@ -194,13 +194,13 @@ class TestObjectBasedAPI(unittest.TestCase): self.assertEqual(monster2.InventoryAsNumpy(), 0) self.assertEqual(monster2.InventoryLength(), 0) self.assertTrue(monster2.InventoryIsNone()) - self.assertTrue(monster2.Color() is 8) + self.assertEqual(monster2.Color(), 8) self.assertEqual(monster2.TestType(), 0) self.assertTrue(monster2.Test() is None) self.assertTrue(monster2.Test4(0) is None) self.assertEqual(monster2.Test4Length(), 0) self.assertTrue(monster2.Test4IsNone()) - self.assertTrue(monster2.Testarrayofstring(0) is '') + self.assertEqual(monster2.Testarrayofstring(0), '') self.assertEqual(monster2.TestarrayofstringLength(), 0) self.assertTrue(monster2.TestarrayofstringIsNone()) self.assertTrue(monster2.Testarrayoftables(0) is None) @@ -212,7 +212,7 @@ class TestObjectBasedAPI(unittest.TestCase): self.assertEqual(monster2.TestnestedflatbufferLength(), 0) self.assertTrue(monster2.TestnestedflatbufferIsNone()) self.assertTrue(monster2.Testempty() is None) - self.assertTrue(monster2.Testbool() is False) + self.assertFalse(monster2.Testbool()) self.assertEqual(monster2.Testhashs32Fnv1(), 0) self.assertEqual(monster2.Testhashu32Fnv1(), 0) self.assertEqual(monster2.Testhashs64Fnv1(), 0) @@ -228,7 +228,7 @@ class TestObjectBasedAPI(unittest.TestCase): self.assertEqual(monster2.Testf(), 3.14159) self.assertEqual(monster2.Testf2(), 3.0) self.assertEqual(monster2.Testf3(), 0.0) - self.assertTrue(monster2.Testarrayofstring2(0) is '') + self.assertEqual(monster2.Testarrayofstring2(0), '') self.assertEqual(monster2.Testarrayofstring2Length(), 0) self.assertTrue(monster2.Testarrayofstring2IsNone()) self.assertTrue(monster2.Testarrayofsortedstruct(0) is None)