From 3a2f6d53008dcf5f5ca43ebcae144f285b44dcc5 Mon Sep 17 00:00:00 2001 From: Wouter van Oortmerssen Date: Thu, 31 May 2018 09:48:34 -0700 Subject: [PATCH] Fixed ASAN false positive. Change-Id: I79d9b2cddc61df5919bc4a93627fba2aa69e5d49 Tested: on Linux. --- src/idl_parser.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/idl_parser.cpp b/src/idl_parser.cpp index d41ad00d3..65ee7ce58 100644 --- a/src/idl_parser.cpp +++ b/src/idl_parser.cpp @@ -135,9 +135,8 @@ inline CheckedError atot(const char *s, Parser &parser, T *val) { int64_t i = StringToInt(s); const int64_t min = flatbuffers::numeric_limits::min(); const int64_t max = flatbuffers::numeric_limits::max(); - ECHECK(parser.CheckInRange(i, min, max)); - *val = (T)i; - return NoError(); + *val = (T)i; // Assign this first to make ASAN happy. + return parser.CheckInRange(i, min, max); } template<> inline CheckedError atot(const char *s, Parser &parser,