mirror of
https://github.com/google/flatbuffers.git
synced 2026-06-29 08:22:00 +00:00
Improved pull request & clang-format instructions.
Change-Id: Ia439bcc61bac5788792244d10e573b1fba54b347
This commit is contained in:
6
.github/PULL_REQUEST_TEMPLATE.md
vendored
6
.github/PULL_REQUEST_TEMPLATE.md
vendored
@@ -1,6 +1,8 @@
|
|||||||
Thank you for submitting a PR!
|
Thank you for submitting a PR!
|
||||||
|
|
||||||
Please make sure you include the names of the affected language(s) in your PR title.
|
Please delete this standard text once you've created your own description.
|
||||||
|
|
||||||
|
Make sure you include the names of the affected language(s) in your PR title.
|
||||||
This helps us get the correct maintainers to look at your issue.
|
This helps us get the correct maintainers to look at your issue.
|
||||||
|
|
||||||
If you make changes to any of the code generators, be sure to run
|
If you make changes to any of the code generators, be sure to run
|
||||||
@@ -11,6 +13,8 @@ If your PR includes C++ code, please adhere to the Google C++ Style Guide,
|
|||||||
and don't forget we try to support older compilers (e.g. VS2010, GCC 4.6.3),
|
and don't forget we try to support older compilers (e.g. VS2010, GCC 4.6.3),
|
||||||
so only some C++11 support is available.
|
so only some C++11 support is available.
|
||||||
|
|
||||||
|
For any C++ changes, please make sure to run `sh src/clang-format-git.sh`
|
||||||
|
|
||||||
Include other details as appropriate.
|
Include other details as appropriate.
|
||||||
|
|
||||||
Thanks!
|
Thanks!
|
||||||
|
|||||||
6
src/clang-format-all.sh
Normal file
6
src/clang-format-all.sh
Normal file
@@ -0,0 +1,6 @@
|
|||||||
|
# Running it twice corrects some bugs in clang-format.
|
||||||
|
for run in {1..2}
|
||||||
|
do
|
||||||
|
clang-format -i -style=file include/flatbuffers/* src/*.cpp tests/*.cpp samples/*.cpp grpc/src/compiler/schema_interface.h grpc/tests/*.cpp
|
||||||
|
done
|
||||||
|
git checkout include/flatbuffers/reflection_generated.h
|
||||||
6
src/clang-format-git.sh
Normal file
6
src/clang-format-git.sh
Normal file
@@ -0,0 +1,6 @@
|
|||||||
|
# Running it twice corrects some bugs in clang-format.
|
||||||
|
for run in {1..2}
|
||||||
|
do
|
||||||
|
git clang-format HEAD^ -- include/flatbuffers/* src/*.cpp tests/*.cpp samples/*.cpp grpc/src/compiler/schema_interface.h grpc/tests/*.cpp
|
||||||
|
done
|
||||||
|
git checkout include/flatbuffers/reflection_generated.h
|
||||||
@@ -1,2 +0,0 @@
|
|||||||
clang-format -i -style=file include/flatbuffers/* src/*.cpp tests/test.cpp samples/*.cpp grpc/src/compiler/schema_interface.h grpc/tests/*.cpp
|
|
||||||
git checkout include/flatbuffers/reflection_generated.h
|
|
||||||
Reference in New Issue
Block a user