From 26f238c24888bf02a872f304fe9f03433fd0dd00 Mon Sep 17 00:00:00 2001 From: Vladimir Glavnyy <31897320+vglavnyy@users.noreply.github.com> Date: Tue, 22 Oct 2019 00:11:32 +0700 Subject: [PATCH] Add `--clean-first` to the cmake-build command (travis) (#5574) - `--clean-first` runs `clean` target to remove previously generated files - missed `monster_extra_generated.h` file added to the `flattests` target --- .travis.yml | 2 +- CMakeLists.txt | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index fd2959f50..e1825fad0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -112,7 +112,7 @@ matrix: -DGRPC_INSTALL_PATH=$TRAVIS_BUILD_DIR/google/grpc/install -DPROTOBUF_DOWNLOAD_PATH=$TRAVIS_BUILD_DIR/google/grpc/third_party/protobuf -DFLATBUFFERS_CODE_SANITIZE=ON - - cmake --build . -- -j${JOBS} + - cmake --build . --target all --clean-first -- -j${JOBS} - LD_LIBRARY_PATH=$TRAVIS_BUILD_DIR/google/grpc/install/lib ctest --extra-verbose --output-on-failure - bash .travis/check-generate-code.sh diff --git a/CMakeLists.txt b/CMakeLists.txt index bda80e7ed..961d0bba0 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -126,6 +126,8 @@ set(FlatBuffers_Tests_SRCS ${CMAKE_CURRENT_BINARY_DIR}/tests/arrays_test_generated.h # file generate by running compiler on tests/native_type_test.fbs ${CMAKE_CURRENT_BINARY_DIR}/tests/native_type_test_generated.h + # file generate by running compiler on tests/monster_extra.fbs + ${CMAKE_CURRENT_BINARY_DIR}/tests/monster_extra_generated.h ) set(FlatBuffers_Sample_Binary_SRCS @@ -311,6 +313,7 @@ if(FLATBUFFERS_BUILD_SHAREDLIB) endif() function(compile_flatbuffers_schema_to_cpp_opt SRC_FBS OPT) + message(STATUS "Add the code-generation command for the `${SRC_FBS}` schema.") get_filename_component(SRC_FBS_DIR ${SRC_FBS} PATH) string(REGEX REPLACE "\\.fbs$" "_generated.h" GEN_HEADER ${SRC_FBS}) add_custom_command( @@ -342,6 +345,9 @@ if(FLATBUFFERS_BUILD_TESTS) compile_flatbuffers_schema_to_cpp(tests/monster_test.fbs) compile_flatbuffers_schema_to_cpp_opt(tests/native_type_test.fbs "") compile_flatbuffers_schema_to_cpp_opt(tests/arrays_test.fbs "--scoped-enums;--gen-compare") + if(NOT (MSVC AND MSVC_VERSION LESS 1900)) + compile_flatbuffers_schema_to_cpp(tests/monster_extra.fbs) # Test floating-point NAN/INF. + endif() include_directories(${CMAKE_CURRENT_BINARY_DIR}/tests) add_executable(flattests ${FlatBuffers_Tests_SRCS}) set_property(TARGET flattests