BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-15 08:48:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes a bug where the create function doesnt optional + required items (#7228)

Browse Source 
Format sh file
This commit is contained in:
mustiikhalil
2022-04-09 00:28:54 +02:00
committed by GitHub
parent d658239484
commit 173ebb6944
5 changed files with 215 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/idl_gen_swift.cpp
View File

@@ -685,7 +685,8 @@ class SwiftGenerator : public BaseGenerator {
"{{TABLEOFFSET}}.{{OFFSET}}.p) }";
code_ += type + "?" + builder_string + create_struct;
/// Optional hard coded since structs are always optional
create_func_header.push_back(field_var + ": " + type + "? = nil");
create_func_header.push_back(field_var + ": " + type +
(field.IsOptional() ? "? = nil" : ""));
return;
}
@@ -694,8 +695,8 @@ class SwiftGenerator : public BaseGenerator {
(IsVector(field.value.type) || IsArray(field.value.type)
? "VectorOffset"
: "Offset");
create_func_header.push_back(arg_label + " " + field_var + ": " +
"Offset = Offset()");
create_func_header.push_back(arg_label + " " + field_var + ": " + "Offset" +
(field.IsRequired() ? "" : " = Offset()"));
const auto reader_type =
IsStruct(field.value.type) && field.value.type.struct_def->fixed
? "structOffset: {{TABLEOFFSET}}.{{OFFSET}}.p) }"