BigfootDev/flatbuffers
1
0
Fork 1
mirror of https://github.com/google/flatbuffers.git synced 2026-06-19 15:45:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move reflection_ts_fbs into a separate directory (#7342)

Browse Source 
Right now, reflection_ts_fbs target is in reflection/BUILD.bazel.

This is not ideal because reflection:reflection_fbs_schema is referenced
from :flatc in the root. Thus, for any Bazel projects that want to
include flatbuffers, they need to include npm / yarn_install and nodejs
support all because reflection/BUILD.bazel loads typescript.bzl and that
requires all TypeScript things.

This PR separated that target into a different subdirectory, freeing
root BUILD.bazel from that dependency.
This commit is contained in:
Liu Liu
2022-06-13 06:36:52 -07:00
committed by GitHub
parent 49e1ea3335
commit 090caa2809
3 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
typescript.bzl
View File

@@ -85,7 +85,7 @@ def flatbuffer_ts_library(
"types": ["node"],
},
},
deps = deps + ["//ts:flatbuffers"] + (["//reflection:reflection_ts_fbs"] if include_reflection else []),
deps = deps + ["//ts:flatbuffers"] + (["//reflection/ts:reflection_ts_fbs"] if include_reflection else []),
)
js_library(
name = name,