forked from BigfootDev/flatbuffers
05cc7a2eff
* fix: correct operator precedence in ForAllFields reverse iteration The expression `size() - i + 1` evaluates as `(size() - i) + 1` due to left-to-right associativity, producing an out-of-bounds index when reverse=true. For a vector of size N, the first iteration (i=0) accesses index N+1, which is 2 past the last valid index. Changed to `size() - (i + 1)` to match the correct implementation already present in bfbs_gen.h:192. Bug: CWE-125 (Out-of-bounds Read), CWE-783 (Operator Precedence Error) * test: add ForAllFieldsReverseTest for reverse iteration correctness Verify that ForAllFields with reverse=true iterates fields in descending ID order. Tests both Stat (3 fields) and Monster (many fields with non-sequential definition order) tables. --------- Co-authored-by: Tulgaa <tulgaa.kek@gmail.com>
21 lines
474 B
C++
21 lines
474 B
C++
#ifndef TESTS_REFLECTION_TEST_H
|
|
#define TESTS_REFLECTION_TEST_H
|
|
|
|
#include <stdint.h>
|
|
|
|
#include <string>
|
|
|
|
namespace flatbuffers {
|
|
namespace tests {
|
|
|
|
void ReflectionTest(const std::string& tests_data_path, uint8_t* flatbuf,
|
|
size_t length);
|
|
void ForAllFieldsReverseTest(const std::string& tests_data_path);
|
|
void MiniReflectFixedLengthArrayTest();
|
|
void MiniReflectFlatBuffersTest(uint8_t* flatbuf);
|
|
|
|
} // namespace tests
|
|
} // namespace flatbuffers
|
|
|
|
#endif
|