BigfootDev/flatbuffers-bigfoot
1
0
Fork 0
forked from BigfootDev/flatbuffers
Code Pull Requests Activity

Fix unused variable warnings across code generators

Browse Source 
Removing `_LIBCPP_DISABLE_UNUSED_STRUCT_WARNINGS` from libc++ enables
`[[gnu::__warn_unused__]]` on standard library types (such as
`std::string` and `std::set`), surfacing `-Wunused-variable` warnings.
See [upstream LLVM commit](https://github.com/llvm/llvm-project/commit/ab8b037ef7b398aa864959a69f328fa69b567f74) for reference.

- Remove unreferenced variable declarations whose initializers have no
  side effects (`generated_functions`, `offset_prefix`, `offset_size`,
  `filebase`, `field_name`, `offset`, `ts_file_path_rel`,
  `ts_file_path`, and `union_accessor`).
- Annotate variables initialized via helper or member calls with
  `[[maybe_unused]]` (`offset_str`, `get_field`, `qualified`,
  `struct_var`, `struct_type`, `type`, `def_mod_name`, and
  `ts_file_path`).

PiperOrigin-RevId: 999136370
This commit is contained in:
Anshul Nigham
2026-10-23 18:40:05 +00:00
committed by Derek Bailey
parent 6dda43bbaa
commit 9698e11376
10 changed files with 9 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/idl_gen_java.cpp
+1 -1
View File
@@ -2176,7 +2176,7 @@ class JavaGenerator : public BaseGenerator {
if (field.deprecated) continue;
if (field.value.type.base_type == BASE_TYPE_UTYPE) continue;
if (field.value.type.element == BASE_TYPE_UTYPE) continue;
const auto get_field = namer_.Method("get", field);
[[maybe_unused]] const auto get_field = namer_.Method("get", field);
code += " this." + namer_.Field(field) + " = ";
const auto type_name =