Static Analysis (#12)

Reviewed-on: #12
Co-authored-by: Romain BOULLARD <romain.boullard@protonmail.com>
Co-committed-by: Romain BOULLARD <romain.boullard@protonmail.com>

Bigfoot/Sources/Utils/Include/Utils/Singleton.hpp

@@ -9,7 +9,6 @@
 
 #include <EASTL/array.h>
 #include <EASTL/bit.h>
-#include <EASTL/optional.h>
 #include <EASTL/type_traits.h>
 #include <EASTL/utility.h>
 
@@ -33,7 +32,7 @@ class Singleton
      */
     static constexpr TYPE& Instance()
     {
-        return ms_instance.value();
+        return *eastl::bit_cast<TYPE*>(ms_instance.data());
     }
 
     class Lifetime
@@ -79,7 +78,9 @@ class Singleton
     template<typename... ARGS>
     static void Initialize(ARGS&&... p_args)
     {
-        ms_instance.emplace(eastl::forward<ARGS>(p_args)...);
+        new (ms_instance.data()) TYPE(eastl::forward<ARGS>(p_args)...);
+
+        ms_initialized = true;
     }
 
     /**
@@ -88,13 +89,20 @@ class Singleton
      */
     static void Finalize()
     {
-        ms_instance.reset();
+        eastl::bit_cast<TYPE*>(ms_instance.data())->~TYPE();
+
+        ms_initialized = false;
     }
 
     /**
      * The singleton.
      */
-    inline static eastl::optional<TYPE> ms_instance;
+    alignas(alignof(TYPE)) inline static eastl::array<std::byte, sizeof(TYPE)> ms_instance;
+
+    /**
+     * Is the singleton initialized?
+     */
+    inline static bool ms_initialized = false;
 };
 }   // namespace Bigfoot
 #endif